MapPalette lag

[luizsusin]

Expected behavior
Plugin work flawlessly.

Observed behavior
Huge freeze.

Steps to reproduce (if known)
Load the plugin. After that, it works normally.
Random freezes can also be seen.

Installed plugins
Plugins (65): AdvancedNMotd, AsyncWorldEdit, AsyncWorldEditBossBar, AuthMe, AutoMessage, BeastWithdraw, BetterShop, BetterSpawners, BetterStackMob, BlockLocker, BlockVersion*, ChestSort, CommandHook, ConsoleSpamFix, CreativeCrates, CustomHeads*, eco, EcoEnchants, EntityDetection, EntityTrackerFixer, Essentials, EssentialsSpawn, FastLogin, GoldenCrates, GriefPrevention, GriefPreventionFlags, GSit, HolographicDisplays, ImageOnMap, IronElevators*, LuckPerms, MarriageMaster, MaxBans, mcMMO, MegaArena, Minepacks, Multiverse-Core, MyPet, NexEngine, NoNetherRoof, PlaceholderAPI, PlugMan, PlusProtection, PowerVIP, ProtocolLib, ProtocolSupport, PvPManager, RevampClans, SamAliases, SimplePortals, SkinsRestorer, sleep-most, spark, SusinEvents*, TAB, Vault, VentureChat, VillagerOptimiser, Vote*, Votifier, Webhooker, Wild, WorldEdit, WorldGuard, zEconomy

Version
Yatopia version git-Yatopia-ver/1.16.5-81 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)

Additional context
This might have to do with PR #308, although it's WIP, I'm not sure if it was implemented afterall.
Thread dump can be seen here: https://paste.ubuntu.com/p/fDswhkS9X6/

[Titaniumtown]

This is due to having too many or too big of maps.

[luizsusin]

That's the point: We don't let our players use it, so they can't create it. The maps are majorly 1x1, we probably don't have more than 30 or 40 1x1 and a few 4x4 (maybe 3 or 4).

[metabrixkt]

Not sure if it's Yatopia bug. Bukkit's MapPalette implementation is very laggy, it can cause tps drop.

edit: accidentally closed, sorry

[luizsusin]

I won't close this issue although now I'm sure it isn't a Yatopia bug, this is just an update on the situation.
I've rewritten the ImageOnMap render code using BKCommonLib's MapColorPalette. The result was a massive improvement in performance.
I hope @epserv can get his PR to work.

[toinouH]

Thank you for your comment. MrBoom took note of this.