Fix compilation error #643
khvzakAnnotations
28 warnings
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
using `map_err` over `inspect_err`:
casper-server/src/middleware/trace.rs#L138
warning: using `map_err` over `inspect_err`
--> casper-server/src/middleware/trace.rs:138:10
|
138 | .map_err(|err| {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
help: try
|
138 ~ .inspect_err(|err| {
139 | let span = otel_cx.span();
140 ~ span.set_status(trace::Status::error(err.to_string()));
|
|
|
the borrowed expression implements the required traits:
casper-server/src/lua/storage.rs#L288
warning: the borrowed expression implements the required traits
--> casper-server/src/lua/storage.rs:288:64
|
288 | Err(err) => Ok(Value::String(lua.create_string(&err.into().to_string())?)),
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `err.into().to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
casper-server/src/lua/storage.rs#L148
warning: the borrowed expression implements the required traits
--> casper-server/src/lua/storage.rs:148:64
|
148 | Err(err) => Ok(Value::String(lua.create_string(&err.into().to_string())?)),
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `err.into().to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
using `map` over `inspect`:
casper-server/src/lua/http/body.rs#L85
warning: using `map` over `inspect`
--> casper-server/src/lua/http/body.rs:85:40
|
85 | _ => Ok(self.read().await?.map(|b| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
85 ~ _ => Ok(self.read().await?.inspect(|b| {
86 ~ *self = LuaBody::Bytes(b.clone());
|
|
|
this function depends on never type fallback being `()`:
casper-server/src/storage/backends/redis/client.rs#L378
warning: this function depends on never type fallback being `()`
--> casper-server/src/storage/backends/redis/client.rs:378:5
|
378 | async fn store_response_inner<'a>(&self, item: Item<'a>) -> Result<usize> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: fred::types::FromRedis` will fail
--> casper-server/src/storage/backends/redis/client.rs:433:22
|
433 | .set(
| ^^^
= note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
|
|
Clippy check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Clippy check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build and test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build and test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build and test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build and test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build and test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build and test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
using `map_err` over `inspect_err`:
casper-server/src/middleware/trace.rs#L138
warning: using `map_err` over `inspect_err`
--> casper-server/src/middleware/trace.rs:138:10
|
138 | .map_err(|err| {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
help: try
|
138 ~ .inspect_err(|err| {
139 | let span = otel_cx.span();
140 ~ span.set_status(trace::Status::error(err.to_string()));
|
|
|
the borrowed expression implements the required traits:
casper-server/src/lua/storage.rs#L288
warning: the borrowed expression implements the required traits
--> casper-server/src/lua/storage.rs:288:64
|
288 | Err(err) => Ok(Value::String(lua.create_string(&err.into().to_string())?)),
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `err.into().to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
casper-server/src/lua/storage.rs#L148
warning: the borrowed expression implements the required traits
--> casper-server/src/lua/storage.rs:148:64
|
148 | Err(err) => Ok(Value::String(lua.create_string(&err.into().to_string())?)),
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `err.into().to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
using `map` over `inspect`:
casper-server/src/lua/http/body.rs#L85
warning: using `map` over `inspect`
--> casper-server/src/lua/http/body.rs:85:40
|
85 | _ => Ok(self.read().await?.map(|b| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
85 ~ _ => Ok(self.read().await?.inspect(|b| {
86 ~ *self = LuaBody::Bytes(b.clone());
|
|
|
this function depends on never type fallback being `()`:
casper-server/src/storage/backends/redis/client.rs#L378
warning: this function depends on never type fallback being `()`
--> casper-server/src/storage/backends/redis/client.rs:378:5
|
378 | async fn store_response_inner<'a>(&self, item: Item<'a>) -> Result<usize> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: fred::types::FromRedis` will fail
--> casper-server/src/storage/backends/redis/client.rs:433:22
|
433 | .set(
| ^^^
= note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
|