Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some of the differences with offical repo #4

Open
twmht opened this issue Jun 14, 2022 · 6 comments
Open

some of the differences with offical repo #4

twmht opened this issue Jun 14, 2022 · 6 comments

Comments

@twmht
Copy link

twmht commented Jun 14, 2022

Hi,

I found out some of the differnces between yours and offical's.

For example, you divide the number of negative point in the loss (https://github.com/ZJCV/overhaul/blob/master/ofd/criterion/ofd_loss.py#L40), why you did this?

another one is that you resize the image to 224x224 (https://github.com/ZJCV/overhaul/blob/master/configs/ofd/resnet/ofd_2_0_r152_pret_r18_c100_224_e100_sgd_mslr.yaml#L26), why you did this?

@zjykzj
Copy link
Member

zjykzj commented Jun 15, 2022

Hi @twmht

for the first question, it is debugged during the actual test. The loss is so big making the training unexpected, dividing the number of mask can make training more steedy

for second question, it's just for use, no obvious tricks. You can try other way

@twmht
Copy link
Author

twmht commented Jun 15, 2022

@zjykzj

The loss is so big making the training unexpected

Yup. I also found out this, the official's division is very weird. but have you ever tested the offical repo? if this is a problem, then official's may not work as expected.

@zjykzj
Copy link
Member

zjykzj commented Jun 15, 2022

@zjykzj

The loss is so big making the training unexpected

Yup. I also found out this, the official's division is very weird. but have you ever tested the offical repo? if this is a problem, then official's may not work as expected.

No tried, just checked some implementations. How about you ? have your try that ?

@twmht
Copy link
Author

twmht commented Jun 15, 2022

I have not tried that. and the paper did not mention about that.

I am going to try and see if any unstable happens.

@twmht
Copy link
Author

twmht commented Jun 15, 2022

by the way, there are some better fix for this repo.

For example,

https://github.com/ZJCV/overhaul/blob/master/ofd/distill/ofd_distiller.py#L24

I think adding bias=False is better since you have bn after that.

@zjykzj
Copy link
Member

zjykzj commented Jun 15, 2022

by the way, there are some better fix for this repo.

For example,

https://github.com/ZJCV/overhaul/blob/master/ofd/distill/ofd_distiller.py#L24

I think adding bias=False is better since you have bn after that.

Nice, give a PR please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants