feat: Add volume control #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In usePlayer hook:
- Add states to control volume:
- playerVolume
- playerMuted
- Add changePlayerVolume function to handle volume change
- Add to the return object:
- playerVolume
- changePlayerVolume
- playerMuted
- setPlayerMuted
- In App component:
- Create a volume slider
- Create a mute/unmute button
- Additionally make formatting changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Volume change while playing - Starting with pre-set volume - Starting already muted by changing volume to zero - Starting already muted by mute button - Muting and unmuting by changing volume while playing - Muting and unmuting using mute button while playing - Changing volume while it's muted and playing - Muting by changing volume to zero and unmuting while playing
- Separate the volume control into a new component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.