-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTC Taproot (BIP340) compatible #439
Comments
Not currently, but it shouldn't be too hard. If anyone is wants to give it a shot, I sketched the changes needed here cfrg/draft-irtf-cfrg-frost@master...conradoplg:draft-irtf-cfrg-frost:taproot (but that's completely untested). I'll leave this open to track it. |
It seems sk_i also need be negated if group_public_key y coordinate is odd. ![]() Here is an implentation https://github.com/jesseposner/FROST-BIP340/blob/main/frost.py |
I've added some testing implementation. Possibly after review it can be added in some way to the upstream code. |
Cool! I haven't reviewed it carefully but it seems about right. If you decide to submit a PR, note that we would prefer to create a separate ciphersuite for it, and not changing the existing secp256k1 one. (this entails basically having a separate folder for it, e.g, frost-taproot or frost-bip340 and changing the Ciphersuite name/ID accordingly). Alternatively you can keep it as separate crate, and just submit a PR for frost-core. |
Ок, I'll look to create a separate crate/ciphersuite. |
I've try add a PR #584 Some more changes are probably needed. |
Hi experts,
Are there any plans to make it BTC Taproot (BIP340) compatible?
The text was updated successfully, but these errors were encountered: