Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve open TODOs in code #560

Open
mpguerra opened this issue Oct 10, 2023 · 4 comments
Open

Resolve open TODOs in code #560

mpguerra opened this issue Oct 10, 2023 · 4 comments

Comments

@mpguerra
Copy link
Contributor

I think we might be able to do this one now that div_ceil has been stabilised in the latest rust release (1.73.0)?

// TODO: remove this function and use `div_ceil()` instead when `int_roundings`

@conradoplg
Copy link
Contributor

We might want to wait a bit. If we do that now then everyone who uses our crates will need to use at least Rust 1.73.0 and that may be too strict. Maybe until the next Rust stable release?

@mpguerra
Copy link
Contributor Author

Scheduling until after next Rust stable release on 2023.11.16

@mpguerra
Copy link
Contributor Author

mpguerra commented Dec 5, 2023

this blocks tagging the stable release

@mpguerra
Copy link
Contributor Author

mpguerra commented Jul 3, 2024

Let's wait until ECC crates are on 1.73.0 as their MSRV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Product Backlog
Development

No branches or pull requests

2 participants