Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Sometimes does not calculate "sell quota" correctly #10

Closed
ajsglist opened this issue May 20, 2024 · 4 comments
Closed

[Bug] Sometimes does not calculate "sell quota" correctly #10

ajsglist opened this issue May 20, 2024 · 4 comments

Comments

@ajsglist
Copy link

hi there,

this issue has popped up occasionally with recent versions. Usually, "sell quota" will find the right value. Occasionally, it will find items that sell for 1 credit too little

image

@ZehsTeam
Copy link
Owner

@ajsglist This happened because there was no possible set of items that total $130 and my sell algorithm doesn't like to oversell. I do want to try and fix this issue in a future update where it'll sell for a little bit extra if an exact amount cannot be found.

@ajsglist
Copy link
Author

yeah, an option to force oversell instead of undersell would be great in the future

thanks!

@ZehsTeam
Copy link
Owner

@ajsglist I will look into adding that when I get the chance.

@ZehsTeam
Copy link
Owner

@ajsglist This has been fixed in the latest update SellMyScrap v1.6.0 - c75eb15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants