Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive on-chain button leads to create invoice screen #1274

Closed
yanascz opened this issue Jan 29, 2023 · 4 comments
Closed

Receive on-chain button leads to create invoice screen #1274

yanascz opened this issue Jan 29, 2023 · 4 comments
Labels
Bug Something isn't working

Comments

@yanascz
Copy link

yanascz commented Jan 29, 2023

Describe the bug

I can understand described behaviour on LN layer but not on the base layer. As a user, I'd expect the above action to generate a new on-chain address.

In addition, when I generate an invoice this way and accidentally close the screen with QR code, the on-chain address is no longer accessible from nowhere.

Reproduce

  1. Tap the On-chain box.
  2. Tap the Receive button.

Zeus version

v0.7.1

Node interface

LND (REST)

Network

Clearnet

Device

iPhone 13

Device operating system

iOS 16.2

Log output

No response

@yanascz yanascz added the Bug Something isn't working label Jan 29, 2023
@kaloudis
Copy link
Contributor

kaloudis commented Mar 9, 2023

One of the challenges here is with LNDHub: detecting whether or not the backend supports on-chain receiving or not.

LNBits and LNBank do not support it, whereas vanilla LNDHub does.

@myxmaster
Copy link
Contributor

Main problem 'Receive on-chain button leads to create invoice screen' is fixed meanwhile. It leads to a screen where you can see a QR and text representation of an on-chain address.

In addition, when I generate an invoice this way and accidentally close the screen with QR code, the on-chain address is no longer accessible from nowhere.

This is still the case though. It doesn't matter which way you do it:

  1. Lightning -> Receive, choose 'Unified' or 'On-chain' on the bottom
  2. Bitcoin -> Receive
    -> You will not be able to access the BTC address which was displayed before.

This is usually not a problem since you can create millions of BTC addresses, but what if I presented a BTC address QR to somebody and expect a payment, and then later want to check/track/do whatever with that exact address on a block explorer e.g.? Not possible.

So, @kaloudis why don't we also save BTC address generation in activity as well?

  • In case it was done via Lightning -> Receive, we could add the BTC address to the data (in case amount threshold was hit and 'Unified' and 'On-chain' was available)
  • In case it was done via Bitcoin -> Receive, we could make an object in activity without amount and expiration etc., but only "Requested Payment", timestamp, BTC address

Am I missing something or would that be possible without any technical problems?

@kaloudis
Copy link
Contributor

kaloudis commented Apr 1, 2024

@myxmaster one thing to consider here is we can only track addresses generated in Zeus. if you're using a second interface like CLI or a web UI, you can easily have an incomplete picture of your addresses

@kaloudis
Copy link
Contributor

kaloudis commented Apr 3, 2024

@myxmaster let's close this one out and take discussion of on-chain address history to #1930 - I have a discovery

@kaloudis kaloudis closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants