Skip to content

Commit

Permalink
refactor: rename updateSteps to updateStepsTexts
Browse files Browse the repository at this point in the history
just thought this clarifies a bit that the function only tries to update the texts of the steps in the sidepanel, not
any other logic
  • Loading branch information
pajlada committed Nov 24, 2024
1 parent 5769eb0 commit 8d41b49
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/main/java/com/questhelper/managers/QuestManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ private void handleSelectedQuest()
{
if (selectedQuest.getCurrentStep() != null)
{
panel.updateSteps();
panel.updateStepsTexts();
QuestStep currentStep = selectedQuest.getCurrentStep().getSidePanelStep();
if (currentStep != null && currentStep != lastStep && panel.questActive)
{
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/questhelper/panel/QuestHelperPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -583,9 +583,9 @@ public void addQuest(QuestHelper quest, boolean isActive)
revalidate();
}

public void updateSteps()
public void updateStepsTexts()
{
questOverviewPanel.updateSteps();
questOverviewPanel.updateStepsTexts();
}

public void updateHighlight(Client client, QuestStep newStep)
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/questhelper/panel/QuestOverviewPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import com.questhelper.util.Fonts;
import lombok.Getter;
import net.runelite.api.Client;
import net.runelite.api.Item;
import net.runelite.api.Skill;
import net.runelite.client.ui.ColorScheme;
import static net.runelite.client.ui.PluginPanel.PANEL_WIDTH;
Expand Down Expand Up @@ -316,7 +315,7 @@ public void mouseClicked(MouseEvent e)
}
}

public void updateSteps()
public void updateStepsTexts()
{
questStepPanelList.forEach(panel -> {
for (QuestStep step : panel.getSteps())
Expand Down

0 comments on commit 8d41b49

Please sign in to comment.