Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While Guthix Sleep: NPC Contact Cyrisus Highlight #1821

Open
mtsadler opened this issue Oct 23, 2024 · 2 comments
Open

While Guthix Sleep: NPC Contact Cyrisus Highlight #1821

mtsadler opened this issue Oct 23, 2024 · 2 comments

Comments

@mtsadler
Copy link

I think the indexer or whatever is used to highlight option during NPC contact has a bug.

Details:

While Guthix Sleeps in United Front stage, there is a step to use NPC Contact on Cyrisus.

Issue:
The highlighter actually highlights Smoggy instead.
(Screenshot is edited to highlight issue, sorry meant to take a pic but cant reproduce at this point because I completed the step)

Screenshot 2024-10-23 at 9 07 01 AM
Haavardaw pushed a commit to Haavardaw/quest-helper that referenced this issue Oct 23, 2024
Two small While Guthix Sleeps changes
206d19b 
Reworded the Item requirement of khazard teleport to show as
"2x Khazard teleports, Ardougne cloak or Spirit tree (3)"

Instead of
"2x Spirit tree (3), Ardougne cloak or Khazard teleport"

As this might look a bit confusing with the 2x spirit tree and the 3 digit after which is well the number, just looks more easily understandable this way.

Also changed the widget highlight to 44 instead of 47 as 47 is Smoggy. Issue was posted about it in
Zoinkwiz#1821
Haavardaw pushed a commit to Haavardaw/quest-helper that referenced this issue Oct 23, 2024
While Guthix Sleeps feedback changes
debda2d 
Reworded the Item requirement of khazard teleport to show as
"2x Khazard teleports, Ardougne cloak or Spirit tree (3)"

Instead of
"2x Spirit tree (3), Ardougne cloak or Khazard teleport"

As this might look a bit confusing with the 2x spirit tree and the 3 digit after which is well the number, just looks more easily understandable this way.

Also changed the widget highlight to 44 instead of 47, as 47 is Smoggy. Issue was posted about it in
Zoinkwiz#1821
@Haavardaw Haavardaw mentioned this issue Oct 23, 2024
Merged
@Haavardaw
Copy link
Contributor

Submitted PR for it, Thank you.
#1824

@mtsadler-branch
Copy link

Thanks man, both changes in that PR LGTM.

The only other thing that may be nice add to WGS is calling out safe spot behind pillar during stat boost/final fight.

I found it cuz I was out of food and pots, and the Slayer Masters will kill the 2 demons for you.

Zoinkwiz pushed a commit that referenced this issue Nov 18, 2024
@Haavardaw
While Guthix Sleeps feedback changes (#1824)
6e025f2 
Reworded the Item requirement of khazard teleport to show as
"2x Khazard teleports, Ardougne cloak or Spirit tree (3)"

Instead of
"2x Spirit tree (3), Ardougne cloak or Khazard teleport"

As this might look a bit confusing with the 2x spirit tree and the 3 digit after which is well the number, just looks more easily understandable this way.

Also changed the widget highlight to 44 instead of 47, as 47 is Smoggy. Issue was posted about it in
#1821

Co-authored-by: Haavardaw <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtsadler @Haavardaw @mtsadler-branch