A Kingdom Divided: Polish #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ele hint also snuck in a rename of the variable
This adds it as recommended for the "The Mysterious Mage" section, and recommended to the overall quest
I'm using the Lovakengj tele here since it's closer than the Arceuus tele This could also use the Arceuus tele tablet or fairy ring, but this felt simplest both to implement & to do as I completed the quest myself
Again keeping it simple since inventory space can be annoying here, and users haven't been prompted to bring a Xeric's Talisman. In a bigger rewrite, asking the user to bring a Xeric's Talisman too might be worth it, and it could then be worth revisiting some of the teleport suggestions for better alternatives. In that alternative, it might be good to point out banking opportunities that flow well with the quest.
…pacebar'd too hard
pajlada
force-pushed
the
quest-polish/a-kingdom-divided
branch
from
d8a3ce9 to
110befe
Compare
pajlada
force-pushed
the
quest-polish/a-kingdom-divided
branch
from
110befe to
2ce8f8c
Compare
Zoinkwiz
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly just adds teleport hints - there's a lot of teleporting around so there are definitely some better routes to take in some places, but it complicates what to bring since the user needs combat gear / food for certain parts.
feat: Add tele to lovakengj hint
feat: Add teleport hint to kill Judge of Yama
feat: Add tele hint to wintertodt
feat: Add another tp hint to Piscarilius
chore: Change the text tele hint for the crate inspection to a real tele hint
feat: Recommend bringing 1 antipoison for "The Mysteruous Mage" step
feat: Add tele hint to get to the Tower of Magic
feat: Tele step to Lord Hosidius
feat: Tele hint to Lady Lovakengj
feat: Add tele hint to Lady Pisc
feat: Add tele hint to Shayzien Encampment
feat: tele to xeric's lookout
feat: Add a tooltip to the Broken redirector if the user lost it or spacebar'd too hard
feat: Use tele feature for fairy ring to mount
feat: Use tele feature for wt camp
feat: use tele hint for killing barbarian warlord in kourend woodlands
feat: tele hint to martin holt in prison
feat: tele hint to Arceuus church
feat: tele hint to chasm of fire
feat: tele hint when heading to the vinery
this loosely hints at using a xeric's talisman, while not highlighting it. it would require a bit of a bigger rework to assume the talisman should be brought, and some more testing so I will leave that up to a future adventurer doing the quest
feat: tele hint for the "speak with all the leaders again" step
chore: Run reformat code
feat: complete quest