Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-working checkRange to make take into account thieving boost #1286

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

marmadukeG
Copy link
Contributor

@marmadukeG marmadukeG commented Sep 24, 2023

Fixes #1273:

Thieving currently has a static max boost of "3", reworking checkRange to be more dynamic.

Copy link
Contributor

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick for the formatting of the solution, otherwise I think this is a good solution for the problem 👍

You could format the code slightly different to make it a little bit more clear what it does, like this:

if (...boosts...) {
  ...
}
else if (skill == THIEVING) {
  if (real thieving level < 65) {
    highestBoost = 2;
  } else if (real thieving level < 45) {
    highestBoost = 1;
  }
}

Then run IntelliJ's formatter on your new code to align it properly

You can add the text: "Fixes #1273 " in the PR description, that way the issue will automatically close when this PR is merged in!

@marmadukeG marmadukeG changed the title Re-working checkRange to make take into account thieving boost Fixes #1273: Re-working checkRange to make take into account thieving boost Sep 24, 2023
@marmadukeG marmadukeG changed the title Fixes #1273: Re-working checkRange to make take into account thieving boost Re-working checkRange to make take into account thieving boost Sep 24, 2023
@Zoinkwiz Zoinkwiz merged commit 5c1ef31 into Zoinkwiz:master Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legends' Quest wrong Thieving boost
3 participants