Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-working checkRange to make take into account thieving boost #1286

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Re-working checkRange to make take into account thieving boost #1286

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9af3647
Re-working checkRange to make take into account thieving boost
marmadukeG Sep 24, 2023
772e8d3
re-factoring with pajlada's comments for readability
marmadukeG Sep 24, 2023
3304d49
ran the code formatter
marmadukeG Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/com/questhelper/requirements/player/SkillRequirement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import lombok.Getter;
import net.runelite.api.Client;
import net.runelite.api.Skill;
import static net.runelite.api.Skill.THIEVING;

/**
* Requirement that checks if a player meets a certain skill level.
Expand Down Expand Up @@ -132,6 +133,14 @@ public boolean checkRange(Skill skill, int requiredLevel, Client client, QuestHe
{
highestBoost = 5;
}
else if (skill == THIEVING && client.getRealSkillLevel(skill) < 65){ //player only has access to Summer sq'irk juice at level 65 thieving which is the default boost value for thieving, currently that's blind to player current skill level
if(client.getRealSkillLevel(skill) >= 45){
highestBoost = 2;
}
else{
highestBoost = 1;
}
}

return requiredLevel - highestBoost <= currentSkill;
}
Expand Down