The Great Brain Robbery: Some polish #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e quests' first step This ensures the "Starting off" category actually expands when you start the quest guide
…ing off category expands
This caused the statue to not be highlighted
…ou messed up and need a tp back
… step already It's not technically required yet, but it would be silly not to have it now
This is technically not a requirement, but for anyone other than a UIM this is good to bring already since it saves a little time banking
It's now a ConditionalStep with all the required steps to head to Harmony copied to make sure progress is kept as expected
making sure there's proper TP steps to get there
…great-brain-robbery
Zoinkwiz
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR diff without the last commit's reformatting: https://github.com/Zoinkwiz/quest-helper/pull/1287/files/76e62ea3c1b2c94ea6c982e88a85711aaa2a10de
Most notably, this fixes ObjectStep's copy function - it didn't copy teleports before.
NpcStep now also has a copy function
The rest of the quest steps were mostly small teleport additions, recovery fixes (e.g. if you teleport away, it will now guide you back easier),
I also made the ectophial tp recommendation also suggest a Mos le'harmless teleport scroll
You're not allowed to bring a pet under water, so I added a hint in the requirements that you shouldn't bring a pet.
I would use the "no follower" thing but you also can't have a pet in your inventory, so I didn't want to give a false sense of "I'm ok" if you just have a pet in your inventory.