Add The Path of Glouphrie #1289

pajlada · 2023-09-25T23:14:26Z

The quest guide should be complete, I'd like to finish it on my second character too, to make sure I haven't missed anything.
After the Java 11 & test PRs have been merged in, I'll do my last force push of this branch.

There are a few changes that should be removed before this gets merged in, like the varbit exporter & the optimal quest order

pajlada · 2023-09-27T23:08:30Z

Latest progress, puzzle solving works when you have the right pieces.
next step is to make it work for when you just have garbage

pog-puzzle.mp4

pajlada · 2023-09-30T20:23:04Z

I ran through the quest with my main now, fixed some phrasing

There's some more wording that can be cleaned up, and the puzzle could help more if you don't have enough discs

video of my main attempt https://www.youtube.com/watch?v=eVZYh87yea4

pajlada · 2023-10-01T10:09:08Z

Currently looking into making the exchanger easier to use

pajlada · 2023-10-01T12:42:53Z

You're now hinted at what should be put in the exchanger (if you have a single-disc exchangable item that would solve things)

(in the current version it would only highlight one item instead of all possible solutions)

When you've exchanged to find a solution, it'll highlight like this:

pajlada · 2023-10-01T12:50:17Z

During the monolith puzzle step, I suggest the player to get discs once from every chest, however some users will not be able to get discs from the last chest because I think the game chests the value of all the discs you have in your inventory, rather than how many discs you have. The check I have now is just for how many discs, so the text is a bit vague saying "if you can't get discs, just drop your discs & then click the chest" - I think this is clear enough since it'd be a bit tricky to implement

Zoinkwiz

Went through the quest once with the following points, I have another account I can do this on too so post any changes I can run through it again!

Zoinkwiz · 2023-10-01T19:25:05Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+		var talkToGianneJnrStep = new ConditionalStep(this, climbUpToGianneJnr);
+		talkToGianneJnrStep.addStep(inGnomeStrongholdFloor1, talkToGianneJnr);
+
+		var talkToLongrambleStep = new ConditionalStep(this, talkToLongramble);


Is there a benefit to wrapping up individual steps in a ConditionalStep, or is this done as a form of consistency/extendability for the future?

This was mostly a "previous steps used this, so I copy pasted it" - this has been resolved in my refactor.
Each section has its own class so loadSteps looks a bit cleaner https://github.com/Zoinkwiz/quest-helper/pull/1289/files#diff-05bf0febe845e8fc2e1c42b80fd499249b45f2b76ac8e215eb65795ad312be41R121-R156

Zoinkwiz · 2023-10-01T19:26:16Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+	{
+		/// Starting off
+		// Talk to King Bolren
+		var teleToBolren = new TeleportItemRequirement("Spirit tree to Tree Gnome Village [1]", -1, -1);


This can be shifted to the setupRequirements section.

Resolved in the refactor https://github.com/Zoinkwiz/quest-helper/pull/1289/files#diff-05bf0febe845e8fc2e1c42b80fd499249b45f2b76ac8e215eb65795ad312be41R99-R100

Zoinkwiz · 2023-10-01T19:26:51Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+		/// Starting off
+		// Talk to King Bolren
+		var teleToBolren = new TeleportItemRequirement("Spirit tree to Tree Gnome Village [1]", -1, -1);
+		talkToKingBolren = new NpcStep(this, NpcID.KING_BOLREN, new WorldPoint(2542, 3169, 0), "Talk to King Bolren in the Tree Gnome Village to start the quest");


Generally for steps we'd have the steps have full stops at the end as punctuation, so it'd be good to do the same for all the steps in this helper too.

Should be resolved in 07539a9 (#1289) and f3bfdd1 (#1289) (and f3bfdd1 )

Zoinkwiz · 2023-10-01T19:30:41Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/MonolithPuzzle.java

+			regionPoint(39, 25)
+		));
+
+		pushSouthernMonolithUp = new NpcStep(getQuestHelper(), NpcID.BIG_MONOLITH, regionPoint(37, 21), "Push the monolith north once");


It'd be good to mark the tile to push from with a tile marker for these steps, WDYT?

I'm open to it, but when I was zooming through it, it didn't feel like it was necessary https://youtu.be/eVZYh87yea4?t=44

Zoinkwiz · 2023-10-01T19:36:47Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/MonolithPuzzle.java

+		pushSmallMonolithSouth = new NpcStep(getQuestHelper(), NpcID.SMALL_MONOLITH, regionPoint(39, 33), "Push the small monolith south once");
+		pushSmallMonolithSouth.setMaxRoamRange(2);
+
+		pushNWMonolithWest = new NpcStep(getQuestHelper(), NpcID.BIG_MONOLITH, regionPoint(36, 33), "Push the north-west monolith west once");


This is an absolute edge-case, but there's two cases of 1: the monolith being pushed all the way to the east (we could highlight it for both tile options), and 2: the SW monolith being pushed up (requires a push down or reset depending on if pushed up once/twice).

This one's more of a nice to have, probably fine to skip it.

I've added a mention of this in the code for future adventurers in 8ffcd66 (#1289) since it would be best to make those sort of changes while in the room

Zoinkwiz · 2023-10-01T20:11:53Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+		enterSewer.addRequirement(combatGear, prayerPotions, food, crystalChime);
+
+		sewer1Ladder = new ObjectStep(this, ObjectID.LADDER_49700, "Climb up the ladder");
+		sewer2Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1529, 4236, 1),


Would be good to clarify directionally where this is given it's out of sight, for anyone not using the map arrows. 'Climb down the ladder to the far east.' or something.

Fixed in df7b1f4 (#1289) - I added directions to the three steps that have the user walk far

Zoinkwiz · 2023-10-01T20:13:14Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+		sewer1Ladder = new ObjectStep(this, ObjectID.LADDER_49700, "Climb up the ladder");
+		sewer2Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1529, 4236, 1),
+			"Climb down the ladder.");
+		sewer2Ladder.addRecommended(protectMissiles);


If the earmuffs reduce damage worth us highlighting to wear them for this section too as recommended.

Fixed in 24f1930 (#1289)

Zoinkwiz · 2023-10-01T20:14:31Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+		sewer3Ladder = new ObjectStep(this, ObjectID.LADDER_49700, new WorldPoint(1529, 4253, 0),
+			"Climb up the ladder.");
+		sewer3Ladder.addRecommended(protectMissiles);
+		sewer4Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1486, 4283, 1),


Suggested change

sewer4Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1486, 4283, 1),

sewer4Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1486, 4282, 1),

Was a tile too far north of the ladder.

Good catch, fixed in 4770490 (#1289)

Zoinkwiz · 2023-10-01T20:16:13Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+			"Kill the Terrorbirds. You can use the pillars around the room to only fight one at a time. They fight with both Melee and Ranged.");
+		bossStep.setAllowMultipleHighlights(true);
+
+		peekHeavyDoor = new ObjectStep(this, NullObjectID.NULL_49909, WorldPoint.fromRegion(5955, 49, 31, 1), "Peek the heavy door");


Suggested change

peekHeavyDoor = new ObjectStep(this, NullObjectID.NULL_49909, WorldPoint.fromRegion(5955, 49, 31, 1), "Peek the heavy door");

peekHeavyDoor = new ObjectStep(this, NullObjectID.NULL_49909, WorldPoint.fromRegion(5955, 49, 31, 1), "Peek through the heavy door.");

Fixed in 45929d6 (#1289)

Zoinkwiz · 2023-10-01T20:25:27Z

src/main/java/com/questhelper/helpers/quests/thepathofglouphrie/ThePathOfGlouphrie.java

+		peekHeavyDoor = new ObjectStep(this, NullObjectID.NULL_49909, WorldPoint.fromRegion(5955, 49, 31, 1), "Peek the heavy door");
+		watchFinalCutscene = new DetailedQuestStep(this, "Watch the final cutscene");
+
+		talkToHazelmere = new NpcStep(this, NpcID.HAZELMERE, new WorldPoint(2678, 3086, 1),


Not certain how, but after the final step the 'Yes.' text on the lamps was highlighting. Not something to be fixed in this, but it seemed there was some weirdness with a step not being properly discarded.

This makes the reward show as "3,000 Agility Experience Lamp"

Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>

…t farther away

… boss steps

…er to get to Gianne jnr.

…hat it's the right disc

…th the first chest key

pajlada · 2023-10-03T18:27:08Z

Currently working on cleaning up the exchange process

… don't actually fall to the ground. You have to speak to Hazelmere

…item

This highlights the exchanger better when a solution with a required exchange happens

…-glouphrie

pajlada · 2023-10-04T11:18:02Z

This quest is now in a testable state again

What's changed outside of the reviews?

For Yewnock's puzzle:

Exchanges now clearly highlight where to insert things, and what buttons to press.
When prompted to switch from the exchanger to the machine, or vice versa, the close button will be highlighted
Refactored the updateSteps function & added a bunch of comments, hopefully making it a bit clearer what's going on
The exchanger now correctly highlights (I had the wrong coordinates chosen)
We try exchanging asap, even if we don't even have a solution for puzzle 1, and only prompt the player to fetch discs if they really really have to. (or if they would have had to exchange multiple discs at the same time - we don't support that)

For the sewer steps:

Earmuffs to-be-equipped or to-be-had are added as recommended as soon as you're prompted to enter the sewer

For the final step:

I incorrectly stated that the lamp(s) that don't fit in your inventory would fall to the ground - this is incorrect (at least for UIM). Instead, say that you need to just make sure you get 4 lamps and if not, talk to Hazelmere again

This is done by: 1) If no solution to the first puzzle is found, try to find valid single-disc exchanges. If this doesn't work, just ask them to get more discs (which was the old solution) 2) If there's a solution to the first puzzle, but not even a partial solution to the second solution, try to find an exchange that would let us get part of the second puzzle complete. Once that's done, the next solution solve will try to use the previous "find exchange for the last part of the second puzzle" method.

If the solution was a double solution, we would previously only check the first item

…the first slot) The third input slot was ignored previously, potentially causing even more confusion to this confusing part.

…exchanger input is correct

Zoinkwiz

Looks good for a release! Thanks for the work on this, excited to have this available to everyone :D

pajlada force-pushed the quest/the-path-of-glouphrie branch 2 times, most recently from 6730256 to 18653b3 Compare September 27, 2023 09:46

pajlada force-pushed the quest/the-path-of-glouphrie branch from 21bf8a8 to 334f6c4 Compare September 28, 2023 10:05

pajlada mentioned this pull request Sep 28, 2023

feat: unit tests, update junit, add mockito & add test job #1291

Merged

pajlada force-pushed the quest/the-path-of-glouphrie branch from 0a72b3d to 81e10c6 Compare September 30, 2023 16:12

pajlada changed the title ~~[WIP] Add The Path of Glouphrie~~ Add The Path of Glouphrie Sep 30, 2023

pajlada marked this pull request as ready for review September 30, 2023 16:13

pajlada force-pushed the quest/the-path-of-glouphrie branch from bef6c94 to 2fd8685 Compare October 1, 2023 11:52

Zoinkwiz requested changes Oct 1, 2023

View reviewed changes

pajlada force-pushed the quest/the-path-of-glouphrie branch from 723012c to 47f11a8 Compare October 1, 2023 20:28

pajlada added 15 commits October 1, 2023 22:29

Add base quest class

cc06f11

Add general requirements

f8c2fd7

Add combat requirements

e5677c6

Add required items

18d129e

Add recommended items

0b9154b

Add an external resource for the quest

79eed25

Remove the list

a764126

feat: Add ExperienceLamp lamp flag

908b3b6

This makes the reward show as "3,000 Agility Experience Lamp"

Add quest rewards

043b8c0

Work on actual quest steps

f71b191

progress on the quest steps

8235c5e

progress

0dd08fe

Work on the puzzle

b17537f

Add unit tests for Yewnock's puzzle machine

ce2ed8f

progress

26f8828

pajlada and others added 10 commits October 1, 2023 23:42

Fix sewer 4 ladder coordinates

4770490

Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>

Peek _through_ the door instead of peek at it

45929d6

Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>

Added a cardinal direciton to the ladder-climbing steps that are a bi…

df7b1f4

…t farther away

Added ear protection (equipped) as a recommended step for the sewer +…

24f1930

… boss steps

Add steps from The Grand Tree quest to make sure you can use the glid…

3c9be97

…er to get to Gianne jnr.

Don't just check for the existance of a disc in the slot, but check t…

d9f0e76

…hat it's the right disc

Add a hint for recovering the crystal chime

ea73424

Try to make sure the user can't get stuck if they leave & re-enter wi…

3099c9b

…th the first chest key

Change the "use exchanger" step text

593cc40

Fix the exchanger coordinates

f142dfd

pajlada added 9 commits October 3, 2023 23:28

Add earmuffs as recommended to the beginner sewer steps

ad824db

In the last step, clarify that lamps that don't fit in your inventory…

de53895

… don't actually fall to the ground. You have to speak to Hazelmere

Solution finding: Make sure puzzleNeeds always has the "to-be-found" …

b8edaa2

…item

Make our static helpers static

86f9584

Remove unused discToValue parameter to loadValuePossibleExchanges

6929a4d

Remove unused ThePathOfGlouphrie member

3df92c4

Clean up & improve solution finding

d9fe61e

This highlights the exchanger better when a solution with a required exchange happens

Mark subscribed parameters as ignored/unused

e1d5fb4

Merge remote-tracking branch 'upstream/master' into quest/the-path-of…

7271c54

…-glouphrie

pajlada added 7 commits October 4, 2023 22:09

Add a unique step for pressing the reset button in the exchanger

5c320b0

add each disc item ID next to the disc addition so I can CTRL+F better

d9141bf

Bugfix: Correctly check ALL IDs of the puzzleNeed

46e602f

If the solution was a double solution, we would previously only check the first item

Bugfix: Check all 3 exchange input slots (even if we only prompt for …

4221fe3

…the first slot) The third input slot was ignored previously, potentially causing even more confusion to this confusing part.

Bugfix for bug I *just* introduced: now *correctly* check if disc in …

5a5040b

…exchanger input is correct

Fix unit tests since more things are exchangable now

e0b155f

Zoinkwiz approved these changes Oct 7, 2023

View reviewed changes

Zoinkwiz merged commit 30a7174 into Zoinkwiz:master Oct 7, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add The Path of Glouphrie #1289

Add The Path of Glouphrie #1289

pajlada commented Sep 25, 2023 •

edited

Loading

pajlada commented Sep 27, 2023

pajlada commented Sep 30, 2023

pajlada commented Oct 1, 2023

pajlada commented Oct 1, 2023

pajlada commented Oct 1, 2023

Zoinkwiz left a comment

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023 •

edited

Loading

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 2, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 2, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023

Zoinkwiz Oct 1, 2023

pajlada Oct 1, 2023

Zoinkwiz Oct 1, 2023

pajlada commented Oct 3, 2023

pajlada commented Oct 4, 2023 •

edited

Loading

Zoinkwiz left a comment

	sewer4Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1486, 4283, 1),
	sewer4Ladder = new ObjectStep(this, ObjectID.LADDER_49701, new WorldPoint(1486, 4282, 1),

	peekHeavyDoor = new ObjectStep(this, NullObjectID.NULL_49909, WorldPoint.fromRegion(5955, 49, 31, 1), "Peek the heavy door");
	peekHeavyDoor = new ObjectStep(this, NullObjectID.NULL_49909, WorldPoint.fromRegion(5955, 49, 31, 1), "Peek through the heavy door.");

Add The Path of Glouphrie #1289

Add The Path of Glouphrie #1289

Conversation

pajlada commented Sep 25, 2023 • edited Loading

pajlada commented Sep 27, 2023

pajlada commented Sep 30, 2023

pajlada commented Oct 1, 2023

pajlada commented Oct 1, 2023

pajlada commented Oct 1, 2023

Zoinkwiz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pajlada Oct 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pajlada commented Oct 3, 2023

pajlada commented Oct 4, 2023 • edited Loading

Zoinkwiz left a comment

Choose a reason for hiding this comment

pajlada commented Sep 25, 2023 •

edited

Loading

pajlada Oct 1, 2023 •

edited

Loading

pajlada commented Oct 4, 2023 •

edited

Loading