fix: Remove deprecated widget API usages #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will replace all WidgetInfo constructor uses
This will replace the WidgetInfo constructor
Translated directly from WidgetInfo.java, but not tested
Replaces WidgetInfo.DIALOG_SPRITE_TEXT with ComponentID.DIALOG_SPRITE_TEXT, same as used in WidgetInfo.java This has been loosely tested with the gem bag dialog, making sure it gets the correct text Replaces WidgetInfo.DIARY_QUEST_WIDGET_TITLE with ComponentID.DIARY_TITLE, same as used in WidgetInfo.java This has not been tested Replaces WidgetInfo.DIALOG_PLAYER_TEXT with ComponentID.DIALOG_PLAYER_TEXT, same as used in WidgetInfo.java This has been loosely tested by talking to an NPC, making sure the widget looks sane Replaces WidgetInfo.CHATBOX_TITLE with ComponentID.CHATBOX_TITLE, same as used in WidgetInfo.java This has been loosely tested by trying to deposit candy to the Great cauldron, which shows the same dialog Replaces WidgetInfo.DIALOG_NPC_TEXT with ComponentID.DIALOG_NPC_TEXT, same as used in WidgetInfo.java This has been loosely tested by talking to an NPC, making sure the widget looks sane Replaces WidgetInfo.DIALOG_NPC_NAME with ComponentID.DIALOG_NPC_NAME, same as used in WidgetInfo.java Replaces WidgetInfo.DIALOG_NPC_HEAD_MODEL with ComponentID.DIALOG_NPC_HEAD_MODEL, same as used in WidgetInfo.java Replaces WidgetInfo.WORLD_MAP_VIEW with ComponentID.WORLD_MAP_MAPVIEW, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.EMOTE_CONTAINER with ComponentID.EMOTES_EMOTE_CONTAINER, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.EMOTE_WINDOW with ComponentID.EMOTES_WINDOW, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.EMOTE_SCROLLBAR with ComponentID.EMOTES_EMOTE_SCROLLBAR, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.BANK_TITLE_BAR with ComponentID.BANK_TITLE_BAR, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.BANK_ITEM_CONTAINER with ComponentID.BANK_ITEM_CONTAINER, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.BANK_SCROLLBAR with ComponentID.BANK_SCROLLBAR, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.BANK_CONTAINER with ComponentID.BANK_CONTAINER, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.BANK_SEARCH_BUTTON_BACKGROUND with ComponentID.BANK_SEARCH_BUTTON_BACKGROUND, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.CHATBOX_CONTAINER with ComponentID.CHATBOX_CONTAINER, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.CHATBOX_FULL_INPUT with ComponentID.CHATBOX_FULL_INPUT, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.ACHIEVEMENT_DIARY_CONTAINER with ComponentID.ACHIEVEMENT_DIARY_CONTAINER, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.RESIZABLE_MINIMAP_DRAW_AREA with ComponentID.RESIZABLE_VIEWPORT_BOTTOM_LINE_MINIMAP_DRAW_AREA, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.RESIZABLE_MINIMAP_STONES_DRAW_AREA with ComponentID.RESIZABLE_VIEWPORT_MINIMAP_DRAW_AREA, same as used in WidgetInfo.java This has not been tested in-game Replaces WidgetInfo.FIXED_VIEWPORT_MINIMAP_DRAW_AREA with ComponentID.FIXED_VIEWPORT_MINIMAP_DRAW_AREA, same as used in WidgetInfo.java This has not been tested in-game
Replaces WidgetID.DIALOG_PLAYER_GROUP_ID with InterfaceID.DIALOG_PLAYER They point to the same value in WidgetID.java This has not been tested in-game Replaces WidgetID.DIALOG_OPTION_GROUP_ID with InterfaceID.DIALOG_OPTION They point to the same value in WidgetID.java This has not been tested in-game Replaces WidgetID.DIALOG_NPC_GROUP_ID with InterfaceID.DIALOG_NPC They point to the same value in WidgetID.java This has not been tested in-game Replaces WidgetID.BANK_GROUP_ID with InterfaceID.BANK They point to the same value in WidgetID.java This has not been tested in-game
pajlada
force-pushed
the
chore/deprecated-widget-api
branch
from
f1b435e to
0f68673
Compare
Zoinkwiz
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on #1324 being merged in first, then this rebased before it can be merged.This has been completedThere were a lot of things here that were not super easy to test, so it is a good idea to go commit by commit here & double check the changes that have been made. I have tried to keep each commit atomic & have it document what it's actually changed.
This PR must be merged in before any further QuestHelper updates can be pushed, see runelite/plugin-hub@db44ca0