fix: Update rag and bone journal check to use DIARY_TEXT #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolve the issue with the the changes to the quest journal ID. A potential issue is that this quest was already known to be a bit laggy due to the amount of checks going on, so having it check all rows for all items may make this worse.
pajlada
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolve the issue with the the changes to the quest journal ID.
A potential issue is that this quest was already known to be a bit laggy due to the amount of checks going on, so having it check all rows for all items may make this worse.
An alternative is to wait until I'm sure on the offset of the widgets from the original positions to then keep all the checks to be a single widget check.