fix: ensure last step is reset on quest shutdown #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures `panel.updateHighlight` is always called once when the quest is started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a quest was shut down, we did not reset the
lastStepvariable inQuestManagerThe
lastStepvariable is used to check if the highlight in the quest helper's side panel should change, and if we don't reset it, then stop & start the same quest, we'll have an active but unhighlighted step.This PR prevents this.
The first commit consolidates all public
QuestManager"shut down quest" functions into a single one to ensure I don't have to copy paste thelastSteplogic elsewhere. It would be good to take an extra look at this to ensure I have missed anything where maybe the background helper should actually remain closed if a quest is shut down in a special way. I tested this to the best of my ability (starting/stopping the "Check all items" quest & other quests, while toggling the "Highlight all items" option on and off) and everything seems to work as expected.