Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update item requirement without dispatch #1864

Merged
merged 2 commits into from
Nov 24, 2024
Merged

fix: update item requirement without dispatch #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05b0c4f
fix: update item requirements asap in the "quest handler"
pajlada Nov 24, 2024
78ff79e
refactor: rename `updateSteps` to `updateStepsTexts`
pajlada Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/questhelper/managers/QuestManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ private void handleSelectedQuest()
{
if (selectedQuest.getCurrentStep() != null)
{
panel.updateSteps();
panel.updateStepsTexts();
QuestStep currentStep = selectedQuest.getCurrentStep().getSidePanelStep();
if (currentStep != null && currentStep != lastStep && panel.questActive)
{
Expand All @@ -165,7 +165,7 @@ private void handleSelectedQuest()
}
if (panel.questActive)
{
clientThread.invokeLater(() -> panel.updateItemRequirements(client));
panel.updateItemRequirements(client);
}
panel.updateLocks();
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/questhelper/panel/QuestHelperPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,9 +583,9 @@ public void addQuest(QuestHelper quest, boolean isActive)
revalidate();
}

public void updateSteps()
public void updateStepsTexts()
{
questOverviewPanel.updateSteps();
questOverviewPanel.updateStepsTexts();
}

public void updateHighlight(Client client, QuestStep newStep)
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/questhelper/panel/QuestOverviewPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import com.questhelper.util.Fonts;
import lombok.Getter;
import net.runelite.api.Client;
import net.runelite.api.Item;
import net.runelite.api.Skill;
import net.runelite.client.ui.ColorScheme;
import static net.runelite.client.ui.PluginPanel.PANEL_WIDTH;
Expand Down Expand Up @@ -316,7 +315,7 @@ public void mouseClicked(MouseEvent e)
}
}

public void updateSteps()
public void updateStepsTexts()
{
questStepPanelList.forEach(panel -> {
for (QuestStep step : panel.getSteps())
Expand Down
Loading