From 55d80d50d7c365f239828d1166cf989d9b9ca884 Mon Sep 17 00:00:00 2001
From: Isaac Connor <isaac@zoneminder.com>
Date: Thu, 4 Jul 2024 10:44:00 -0400
Subject: [PATCH] Use monitors instead of monitorData as the array to traverse.
  Somehow we end up with there not being an entry in monitors when there is
 one in monitorData. Maybe when visibility events occur during InitPage?
 Anyways, if we are actually traversing monitors, then we should do so in the
 for loop.

---
 web/skins/classic/views/js/montage.js | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/web/skins/classic/views/js/montage.js b/web/skins/classic/views/js/montage.js
index d7ef1381f2..5ffed84bbe 100644
--- a/web/skins/classic/views/js/montage.js
+++ b/web/skins/classic/views/js/montage.js
@@ -504,7 +504,7 @@ function reloadWebSite(ndx) {
 }
 
 function takeSnapshot() {
-  for (let i = 0, length = monitorData.length; i < length; i++) {
+  for (let i = 0, length = monitors.length; i < length; i++) {
     monitors[i].kill();
   }
   const monitor_ids = monitorData.map((monitor)=>{
@@ -557,7 +557,7 @@ function handleClick(evt) {
 }
 
 function startMonitors() {
-  for (let i = 0, length = monitorData.length; i < length; i++) {
+  for (let i = 0, length = monitors.length; i < length; i++) {
     const obj = document.getElementById('liveStream'+monitors[i].id);
     if (obj.src) {
       const url = new URL(obj.src);
@@ -576,7 +576,7 @@ function startMonitors() {
 }
 
 function stopMonitors() { //Not working yet.
-  for (let i = 0, length = monitorData.length; i < length; i++) {
+  for (let i = 0, length = monitors.length; i < length; i++) {
     //monitors[i].stop();
     //monitors[i].kill();
     monitors[i].streamCommand(CMD_QUIT);
@@ -585,13 +585,13 @@ function stopMonitors() { //Not working yet.
 }
 
 function pauseMonitors() {
-  for (let i = 0, length = monitorData.length; i < length; i++) {
+  for (let i = 0, length = monitors.length; i < length; i++) {
     monitors[i].pause();
   }
 }
 
 function playMonitors() {
-  for (let i = 0, length = monitorData.length; i < length; i++) {
+  for (let i = 0, length = monitors.length; i < length; i++) {
     monitors[i].play();
   }
 }
@@ -1016,7 +1016,7 @@ function setTriggerChangedMonitors(id=null) {
 }
 
 function checkEndMonitorsPlaced() {
-  for (let i = 0, length = monitorData.length; i < length; i++) {
+  for (let i = 0, length = monitors.length; i < length; i++) {
     const id = monitors[i].id;
 
     if (!movableMonitorData[id].stop) {
@@ -1042,7 +1042,7 @@ function checkEndMonitorsPlaced() {
     }
   }
   if (monitorsEndMoving) {
-    for (let i = 0, length = monitorData.length; i < length; i++) {
+    for (let i = 0, length = monitors.length; i < length; i++) {
       //Clean for later use
       movableMonitorData[monitors[i].id] = {'width': 0, 'stop': false};
     }
@@ -1115,14 +1115,14 @@ document.onvisibilitychange = () => {
     TimerHideShow = clearTimeout(TimerHideShow);
     TimerHideShow = setTimeout(function() {
       //Stop monitors when closing or hiding page
-      for (let i = 0, length = monitorData.length; i < length; i++) {
+      for (let i = 0, length = monitors.length; i < length; i++) {
         monitors[i].kill();
       }
     }, 15*1000);
   } else {
     TimerHideShow = clearTimeout(TimerHideShow);
     //Start monitors when show page
-    for (let i = 0, length = monitorData.length; i < length; i++) {
+    for (let i = 0, length = monitors.length; i < length; i++) {
       if (!monitors[i].started) {
         monitors[i].start();
       }