Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous warning from VoxelBlockyType of unspecified variants with no variants #673

Open
Osiris32-and-a-half opened this issue Jul 8, 2024 · 2 comments

Comments

@Osiris32-and-a-half
Copy link

Describe the bug
When using VoxelBlockyTypes with a block that has 0 Attributes a node configuration warning is generated specifying that the type has 1 unspecified variants. Without a Attribute it is also impossible to set any variants making the warning impossible to get rid of.

To Reproduce
Steps to reproduce the behavior:

  1. Create a VoxelTerrain Node in a scene.
  2. Set the VoxelTerrain's mesher to VoxelMesherBlocky with a VoxelBlockyTypeLibrary.
  3. Create a new VoxelBlockyType in that VoxelBlockyTypeLibrary .
  4. See error as warning on the VoxelTerrain Node.
  5. Error still exists with a base model set.

Expected behavior
No warning to be produced when a

Screenshots
If applicable, add screenshots to help explain your problem.
image

Environment

  • OS: Windows
  • Graphics card NVIDIA GeForce RTX 4060 Laptop GPU
  • Godot version v4.2.2.stable.custom_build
  • Module version 1.2.0
  • Renderer used Forward+
@MGilleronFJ
Copy link

That probably happens because the type does have a variant, the default one. But the logic might have trouble accounting for that.

Keep in mind blocky types are an unfinished feature in experimental state (which ended up in the main branch only due to difficulty to cherry pick changes from elsewhere that were not experimental). This issue is actually known (and likely others), just not worked on at the moment.

@Zylann
Copy link
Owner

Zylann commented Jul 8, 2024

Pushed a change in 28e2e67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants