-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Open bookmark in [container] (talk to the (integrate the contextualIdentities api) #32
Comments
Hello @v00p , interesting, I didn't know that, thank you. However, there is a problem:
This means that if I include the That is clearly an undesirable effect. Too bad they made that choice in FF API design. Therefore, we should wait for the functionality to be present officially in normal FF builds. Meanwhile, I suggest that people who want to use it simply open a new Window or new tab using the File menu as explained in https://wiki.mozilla.org/Security/Contextual_Identity_Project/Containers, and then use the add-on within it. Let me know your thoughts. |
@aaFn I agree. And this feature is so rarely updated, I don't expect them to add this functionnality anytime soon.. One way would be to branch your current extension in two versions. The "non-Container-ready" version (current), and a (new) "Container-ready" one.. I wonder if the browser.contextualIdentities.query function alone require that "contextualIdentities" permission ... |
Hello @v00p , it looks like yes, it needs it. I also did a little more digging, there is a flaw in that API: it can just manipulate (= create, delete, change) a contextual identity .. but an add-on is not able to select the current contextual identity through that API (or any other as I could see). Therefore, for an add-on like BSP2 which had to recreate a UI in the sidebar, building its own context menus for opening bookmarks in new tabs or in new windows, (for example), there won't be a way to specify which contextual identity to use. The only way will be through the File menu and native FF actions, until the selection capability is added to the API .. :-( Or let me know if you ever see a way to do that. |
Hi @aaFn |
Hello @v00p, I looked at the code and I believe I now get an idea of how they open tabs in specific container. So opening a link in another container is a matter of calling with the specific This seems to confirm it: Infocatcher/Private_Tab#254 Next should be to wait that this becomes mainline, and then I can include it in BSP2. |
@aaFn Good stuff. Can't wait someone sort this out ;)
|
Very expected this feature got implemented. |
Hello @april4 , ok. This is still not yet mainstream in FF, so still waiting for FF to formally publish the function to enable it .. unless I can find a way to not force it to activate when the user did not activate it by himself. |
Being able to Open bookmark in any specified container has been made possible since march 13th of this years. The official Mozilla Firefox Container addons itself haven't yet integrated this capability however.
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/contextualIdentities
The text was updated successfully, but these errors were encountered: