-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can’t find the link in the source document, after already detecting it and showing a button #20
Comments
This is actually a different bug, but interesting. Technically your page does not have a link to Jeremy's page, since your source HTML contains <data class="u-in-reply-to" value="https://stream.jeremycherfas.net/2017/ive-been-thinking-about-robs-post-and-your-notes-on"> Data elements are not web links, so Telegraph's error message is correct. However when the Microformats parser parses the page it sees the in-reply-to URL as a valid URL. So the actual bug with Telegraph is that link should never have been included as an option to send to in the first place. |
Upon reading the Webmention spec again, specifically verification, I agree that my implementation might be wrong. I think Telegraph shouldn’t be using the mf2 parser at all if it only implements Webmention. Though I think the “other similar links” in “look for
So the (This might need to be moved to an issue on the Webmention spec.) |
So turns out the method that finds that initial list of links is in the mention-client-php library. I've filed an issue there accordingly: indieweb/mention-client-php#33 |
I was trying to send a Webmention from
https://licit.li/59997fedcc6ab
tohttps://stream.jeremycherfas.net/2017/ive-been-thinking-about-robs-post-and-your-notes-on
. It correctly detects the link, but when I click the “Send Webmention” button it ends up in an endless spinner and the following is returned fromhttps://telegraph.p3k.io/webmention
:I would expect the spinner to stop and show an error when Telegraph returns an error to the request, telling me as user that something went wrong.
Though I would also expect it to send this mention as it was able to detect the link prior to me clicking the button.
The text was updated successfully, but these errors were encountered: