Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel tox env launching for Windows again #78

Open
5 tasks
abelcheung opened this issue Dec 19, 2024 · 0 comments
Open
5 tasks

Enable parallel tox env launching for Windows again #78

abelcheung opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request testsuite Issues concerning test suite

Comments

@abelcheung
Copy link
Owner

abelcheung commented Dec 19, 2024

Some light of hope exists to enable tox run-parallel again on Windows. It was disabled in e651dc1 due to multiple issues:

  1. Most likely multiple workflows using different python interpreters and setup-uv writing cache simultaneously using the same Windows temp folder name, causing conflict.
  2. Multiple concurrent envs also cause pyright to create file simultaneously on the same cache folder (Concurrent runs of pyright can result in race condition RobertCraigie/pyright-python#318).
    • Solution: Switching to basedpyright could fix this issue by pre-bundling node and pyright and avoid multiple package download from net.
    • Task: Rename everywhere in config, and duplicate config for basedpyright
    • Task: Verify calling basedpyright in pytest plugin causes no surprise
    • Task: build and test GitHub workflows calls basedpyright
    • Task (optional): Can jakebailey/pyright-action and jordemort/action-pyright use basedpyright? Former one seems fine, but latter one may need forking.
@abelcheung abelcheung added enhancement New feature or request testsuite Issues concerning test suite labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testsuite Issues concerning test suite
Projects
Status: No status
Development

No branches or pull requests

1 participant