Make clippy happy

vsvg-core/src/document/document.rs

@@ -1,5 +1,5 @@
-use super::*;
-use crate::{Layer, PageSize, Path};
+use super::{DocumentMetadata, DocumentTrait, FlattenedDocument, LayerID};
+use crate::{Layer, PageSize, Path, Transforms};
 use std::collections::BTreeMap;
 
 #[derive(Default, Clone, Debug)]
@@ -80,7 +80,7 @@ impl Document {
 #[cfg(test)]
 mod test {
     use super::*;
-    use crate::Layer;
+    use crate::{Layer, LayerTrait};
 
     #[test]
     fn test_document_bounds() {

vsvg-core/src/document/flattened_document.rs

@@ -1,5 +1,6 @@
-use super::*;
-use crate::{FlattenedLayer, FlattenedPath, Polyline};
+use super::{DocumentMetadata, DocumentTrait, LayerID};
+use crate::{FlattenedLayer, FlattenedPath, Polyline, Transforms};
+use std::collections::BTreeMap;
 
 #[derive(Default, Clone, Debug)]
 pub struct FlattenedDocument {

vsvg-core/src/document/mod.rs

@@ -1,6 +1,7 @@
 use crate::{LayerTrait, PathDataTrait, PathTrait, Transforms};
 use std::collections::BTreeMap;
 
+#[allow(clippy::module_inception)]
 mod document;
 mod flattened_document;
 mod metadata;

vsvg-core/src/layer/flattened_layer.rs

@@ -1,5 +1,5 @@
-use super::*;
-use crate::{FlattenedPath, Polyline};
+use super::{LayerMetadata, LayerTrait};
+use crate::{FlattenedPath, Polyline, Transforms};
 
 #[derive(Default, Clone, Debug)]
 pub struct FlattenedLayer {

vsvg-core/src/layer/layer.rs

@@ -1,5 +1,5 @@
-use super::*;
-use crate::{FlattenedPath, Path, PathTrait};
+use super::{FlattenedLayer, LayerMetadata, LayerTrait, Transforms};
+use crate::{FlattenedPath, Path, Point};
 
 #[derive(Default, Clone, Debug)]
 pub struct Layer {

vsvg-core/src/layer/mod.rs

@@ -1,4 +1,5 @@
 mod flattened_layer;
+#[allow(clippy::module_inception)]
 mod layer;
 mod metadata;
 
@@ -42,7 +43,7 @@ pub trait LayerTrait<P: PathTrait<D>, D: PathDataTrait>: Default + Transforms {
         }
 
         let mut new_paths = Vec::with_capacity(self.paths().len());
-        let mut index = builder.build(&self.paths());
+        let mut index = builder.build(self.paths());
 
         let mut pos = Point::ZERO;
         while let Some((path_item, reverse)) = index.pop_nearest(&pos) {

vsvg-core/src/optimization.rs

@@ -10,6 +10,7 @@ impl Layer {
         self.sort_with_builder(IndexBuilder::default().flip(flip));
     }
 
+    #[allow(clippy::missing_panics_doc)]
     pub fn sort_with_builder(&mut self, builder: IndexBuilder) {
         if self.paths.len() <= 1 {
             return;

vsvg-core/src/path/flattened_path.rs

@@ -9,22 +9,25 @@ use kurbo::Affine;
 pub struct Polyline(Vec<Point>);
 
 impl Polyline {
+    #[must_use]
     pub fn new(points: Vec<Point>) -> Self {
         Self(points)
     }
 
+    #[must_use]
     pub fn points(&self) -> &[Point] {
         &self.0
     }
 
+    #[must_use]
     pub fn points_mut(&mut self) -> &mut Vec<Point> {
         &mut self.0
     }
 }
 
 impl Transforms for Polyline {
     fn transform(&mut self, affine: &Affine) {
-        for point in self.points_mut().iter_mut() {
+        for point in self.points_mut() {
             *point = *affine * *point;
         }
     }

vsvg-core/src/path/mod.rs

@@ -1,5 +1,6 @@
 mod flattened_path;
 mod metadata;
+#[allow(clippy::module_inception)]
 mod path;
 mod point;
 

vsvg-core/src/path_index.rs

@@ -169,7 +169,7 @@ impl<'a, P: PathTrait<D>, D: PathDataTrait> PathIndex<'a, P, D> {
 
         // update k-d tree
         self.tree = KdTree::new(2);
-        for (idx, path_item) in self.paths.iter() {
+        for (idx, path_item) in &self.paths {
             if let Some(ref start) = path_item.start {
                 if self.settings.flip {
                     if let Some(ref end) = path_item.end {
@@ -204,6 +204,7 @@ impl<'a, P: PathTrait<D>, D: PathDataTrait> PathIndex<'a, P, D> {
     ///
     /// This function may return `None` even if the `PathIndex` is not empty, as some paths may not
     /// be indexed.
+    #[allow(clippy::missing_panics_doc)]
     pub fn pop_nearest(&mut self, point: &Point) -> Option<(PathItem<P, D>, bool)> {
         if self.reindex_agent.should_reindex() {
             self.reindex();

vsvg-core/src/svg_reader.rs

@@ -7,8 +7,7 @@ use std::fs;
 use std::path;
 
 use crate::{
-    Color, Document, DocumentTrait, Layer, LayerID, LayerTrait, PageSize, Path, PathMetadata,
-    PathTrait,
+    Color, Document, DocumentTrait, Layer, LayerID, LayerTrait, PageSize, Path, PathTrait,
 };
 
 use usvg::utils::view_box_to_transform;

vsvg-multi/src/multi_viewer.rs

@@ -18,7 +18,7 @@ impl MultiViewer {
 impl eframe::App for MultiViewer {
     fn update(&mut self, ctx: &egui::Context, _frame: &mut eframe::Frame) {
         // handle input
-        if !ctx.wants_keyboard_input() {}
+        //if !ctx.wants_keyboard_input() {}
 
         egui::SidePanel::left("left_panel").show(ctx, |ui| {
             ui.input(|i| {

vsvg-viewer/src/lib.rs

@@ -15,6 +15,8 @@ use std::error::Error;
 use std::sync::Arc;
 use vsvg_core::Document;
 
+/// Show a document in a window.
+#[allow(clippy::missing_panics_doc)]
 pub fn show(document: &Document) -> Result<(), Box<dyn Error>> {
     let native_options = eframe::NativeOptions::default();
     let document_data = Arc::new(DocumentData::new(document));

vsvg/src/commands.rs

@@ -1,7 +1,6 @@
 use crate::cli::{CommandDesc, CommandValue};
 use clap::{arg, value_parser, Arg, Id};
 use std::collections::HashMap;
-use std::io::Write;
 use vsvg_core::{DocumentTrait, IndexBuilder, Transforms};
 
 // https://stackoverflow.com/a/38361018/229511