Replies: 1 comment
-
Sure.
Bot detection is a much broader subject and not something we focus heavily on detecting. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi!
I'm a second year CS student trying to understand your code. Can I ask a few questions?
I'm asking about your Puppeteer Extra detection, where you're checking various APIs (throwing errors etc.) to see if we can detect Puppeteer Extra is being used.
Why are you using such a complex set of iframes for the tests? (creating an iframe in the main window document, then creating another iframe (getPhantomIframe), then another (getBehemothIframe)...) Why not just create one iframe in the main window document and do the tests there?
How did you choose which API functions to test? I find it hard to believe you tested every possible API and its functions and properties, checked the results in Chrome, and then checked them in Puppeteer Extra. If you can recall and share your process on this I'd really appreciate it! Also I notice you're only looking at a subset of the test for FakeBrowser - can you remember why that is?
The code is a little bit complex and hard to understand. Is all this complexity necessary, or is the code in an experimental "needs to be cleaned up" state? I'm not criticising anything, the problem is probably me, but I'm curious as to your opinion on the current state of the code.
Could your logic be applied to other bots? For example, if we got the hashes of Selenium bots, could we use your code to check for them too, or is there a reason this wouldn't work?
Thank you for your time!
Beta Was this translation helpful? Give feedback.
All reactions