Replies: 7 comments 34 replies
-
|
@Lyncredible |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the new RC. A minor comment: I found the information about the running version clearer in discussions about previous alpha releases. For instance, the one in the screenshot below from
At least, I will welcome an explanation about the part Thanks! |
Beta Was this translation helpful? Give feedback.
-
Sorry I am not able to do it until the end of August. I am traveling out of country and don't have access to my setup. I can test once I am back in a couple of weeks. |
Beta Was this translation helpful? Give feedback.
-
Not a problem at all - enjoy the travel |
Beta Was this translation helpful? Give feedback.
-
|
As the first [!CAUTION] reads up in this page, once we use OneDrive Client for Linux v2.5.0 against one Microsoft OneDrive account, whatever kind of use we do ("regular" files and folders, SharePoint libraries, or OneDrive Business shared items, files or folders), we never can use again OneDrive Client for Linux 2.4.x against the same Microsoft OneDrive account. Am I right? If yes, I need help understanding why. I guess that the changes in the functioning of v2.5.x somehow affects the original data, and those modifications prevent the use of previous versions of the v2.4.x series. Would it be advisable for the client to check if it can or can not be used against a givenMicrosoft OneDrive account? Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
In addition to this, please review the client architecture documentation so that you can understand how the v2.5.x client is operating. |
Beta Was this translation helpful? Give feedback.
-
Of course, I will follow your advice! Thanks! I'm a bit concern about promoting the use of this client, considering it is possible to screw up a thing on the server side by using it the wrong way. Would it be possible to add some new feature that prevent, for instance, to connect two OneDrive for Linux clients using the same Microsoft OneDrive account? Or to avoid trying to connect a 2.4.x OneDrive for Linux client to a Microsoft OneDrive that have already been used by a 2.5.x OneDrive for Linux client? Thank you very much for your work! |
Beta Was this translation helpful? Give feedback.
-
My bad! It is the first time I reach that page. I will study it! Thanks! |
Beta Was this translation helpful? Give feedback.
-
The only way to do this by not following advice. The v2.5.x application checks for options that have changed, such as shared folders implementation and prevents execution to avoid as much as possible folk not reading the new documentation. I have made as much effort as possible to put appropriate safeguards in. But folk can choose to do whatever they want .. my advice is dont use v2.4.x and v2.5.x clients at the same time using the same account.
100% not possible to do something like that - sorry. |
Beta Was this translation helpful? Give feedback.
-
Please review all documentation as most have been totally overhauled. |
Beta Was this translation helpful? Give feedback.
-
|
@Lyncredible Unsure how your testing has gone thus far (or even started) .. but the importance of your testing is less now due to my environment finally being fixed post equipment replacement. |
Beta Was this translation helpful? Give feedback.
-
|
Done: #2792 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks - and merged |
Beta Was this translation helpful? Give feedback.
-
|
I fixed another bug in #2794: the client crashes when it tries and fails to generate a new access token. This is because the Here are some logs that demonstrate the crash. Notice the |
Beta Was this translation helpful? Give feedback.
-
|
Thanks .. interesting that this didnt show in my testing - but thanks for the fix - greatly appreciated. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, it takes some time to repro. Basically I let it run overnight and saw a few crashes. I think it happens after 1 hour when the access token has expired. That is all I have. The RC3 has been running smoothly for me otherwise. |
Beta Was this translation helpful? Give feedback.
-
|
Important With a little over 2 weeks to go before v2.5.0 is formally released, can I please get some updated feedback from anyone testing v2.5.0 RC3 please. |
Beta Was this translation helpful? Give feedback.
-
|
I have not had any issues with RC3 so far. |
Beta Was this translation helpful? Give feedback.
-
|
Small typo in the Note the "DEPRECIATED" instead of "DEPRECATED" |
Beta Was this translation helpful? Give feedback.
-
|
This should be fixed via 46e4e0e - thanks for catching this. |
Beta Was this translation helpful? Give feedback.
-
|
To all those testing v2.5.0 RC3 Last call for any issues or problems you have encountered with RC3. Outside of #2796 (with the fix yet to be integrated to RC3) are there any other issues or problems? Please let me know either way - no issues or problem. |
Beta Was this translation helpful? Give feedback.
-
|
No issues on my side. Running it on AlmaLinux 9.4 and 8.10. Very simple configurations: default on servers with 8.10 and Thanks for your great work! |
Beta Was this translation helpful? Give feedback.
-
|
My OneDrive client Reproduction steps:
mkdir -p ~/OneDrive/TestDir/CrashMe
touch ~/OneDrive/TestDir/crashme
./onedrive --confdir='/home/bob/.config/onedrive/accounts/bpozdena@company.com' --monitor -vvv --debug-https | tee -a onedrive9.log
...
DEBUG: Attempting to query OneDrive API for this path: ./TestDir/CrashMe
DEBUG: parentItem details: Item("b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx", "YYY", "TestDir", "", dir, "\"{A8E8F956-C94E-4925-AB98-AAAAA},1\"", "\"c:{A8E8F956-C94E-4925-AB98-AAAAA},0\"", 2024-Sep-13 10:00:06Z, "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx", "", "", "", "", "", none, "Y", "")
DEBUG: Standard Query, use parentItem
DEBUG: Selecting getPathDetailsByDriveId to query OneDrive API for path data
DEBUG: Request URL = https://graph.microsoft.com/v1.0/drives/b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/root:/.%2FTestDir%2FCrashMe:?select=id,name,eTag,cTag,deleted,file,folder,root,fileSystemInfo,remoteItem,parentReference,size
DEBUG: Existing Microsoft OneDrive Access Token Expires: 2024-Sep-13 13:19:12.5421407
DEBUG: HTTP Response Headers: [xxx]
DEBUG: HTTP Status Line: 404 (2.0)
DEBUG: CurlEngine cleanup() called on instance id: mlUV1AAAAAAAAA
DEBUG: Microsoft Graph API Response:
----
{"error":{"code":"itemNotFound","message":"The resource could not be found."}}
----
DEBUG: Handling a OneDrive API exception:
DEBUG: Curl debugging:
< get https://graph.microsoft.com/v1.0/drives/b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/root:/.%2FTestDir%2FCrashMe:?select=id,name,eTag,cTag,deleted,file,folder,root,fileSystemInfo,remoteItem,parentReference,size
< 404 Not Found (2.0)
> strict-transport-security: max-age=31536000
> x-ms-ags-diagnostic: {"ServerInfo":{"DataCenter":"Germany West Central","Slice":"E","Ring":"4","ScaleUnit":"004","RoleInstance":"FR2PEPF0000038F"}}
> date: Fri, 13 Sep 2024 10:00:06 GMT
> client-request-id: 0ae4f05d-362c-41d4-9b1e-
> request-id: 0ae4f05d-362c-41d4-9b1e-
> cache-control: no-store, no-cache
> content-type: application/json; odata.metadata=minimal; odata.streaming=true; IEEE754Compatible=false; charset=utf-8
Curl response:
----
{"error":{"code":"itemNotFound","message":"The resource could not be found."}}
----
DEBUG: onedrive.OneDriveApi.getPathDetailsByDriveId() - Generated a OneDriveException
DEBUG: The requested directory to create was not found on OneDrive - creating remote directory: ./TestDir/CrashMe
DEBUG: requiredDriveId: b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: requiredParentItemId: YYY
DEBUG: newDriveItem JSON: {"folder":{},"name":"CrashMe"}
DEBUG: Request URL = https://graph.microsoft.com/v1.0/drives/b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/items/YYY/children
DEBUG: Existing Microsoft OneDrive Access Token Expires: 2024-Sep-13 13:19:12.5421407
DEBUG: HTTP Response Headers: [xxx]
DEBUG: HTTP Status Line: 201 (2.0)
DEBUG: CurlEngine cleanup() called on instance id: mlUV1AAAAAAAAA
DEBUG: Microsoft Graph API Response:
----
XXX
----
DEBUG: saveItem - creating DB item from this JSON: {""}
DEBUG: Flagging object as a directory
DEBUG: Successfully created the remote directory ./TestDir/CrashMe on Microsoft OneDrive
DEBUG: OneDrive API releaseCurlEngine() Called
DEBUG: CurlEngine releaseEngine() called on instance id: mlUV1AAAAAAAAA
DEBUG: CurlEngine curlEnginePool size before release: 2
DEBUG: CurlEngine cleanup() called on instance id: mlUV1AAAAAAAAA
DEBUG: CurlEngine curlEnginePool size after release: 3
DEBUG: New items to upload to Microsoft OneDrive: 1
DEBUG: Total New Data to Upload: 0 Bytes
DEBUG: Current Available Space Online (b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx): 509479 MB
DEBUG: Upload Thread 0 Starting: 2024-Sep-13 12:00:07.6033465
DEBUG: fileToUpload: ./TestDir/crashme
DEBUG: This Thread Estimated Free Space Online: 534227529666
DEBUG: This Thread Calculated Free Space Online Post Upload: 534227529666
DEBUG: CurlEngine getCurlInstance() called
DEBUG: CurlEngine curlEnginePool current size: 3
DEBUG: CurlEngine was in a valid state - returning existing CurlEngine instance
DEBUG: CurlEngine instance ID: mlUV1AAAAAAAAA
DEBUG: http.dnsTimeout = 60
DEBUG: http.connectTimeout = 10
DEBUG: http.dataTimeout = 5
DEBUG: http.operationTimeout = 3600
DEBUG: http.maxRedirects = 5
DEBUG: http.CurlOption.ipresolve = 0
DEBUG: http.header.Connection.keepAlive = true
DEBUG: Read token from appConfig
DEBUG: Authorised State: true
DEBUG: Request URL = https://graph.microsoft.com/v1.0/drives/b!xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/root:/.%2FTestDir%2Fcrashme:?select=id,name,eTag,cTag,deleted,file,folder,root,fileSystemInfo,remoteItem,parentReference,size
DEBUG: Existing Microsoft OneDrive Access Token Expires: 2024-Sep-13 13:19:12.5421407
DEBUG: HTTP Response Headers: [xxx]
DEBUG: HTTP Status Line: 200 (2.0)
DEBUG: CurlEngine cleanup() called on instance id: mlUV1AAAAAAAAA
DEBUG: Microsoft Graph API Response:
----
XXX
----
DEBUG: OneDrive API releaseCurlEngine() Called
DEBUG: CurlEngine releaseEngine() called on instance id: mlUV1AAAAAAAAA
DEBUG: CurlEngine curlEnginePool size before release: 2
DEBUG: CurlEngine cleanup() called on instance id: mlUV1AAAAAAAAA
DEBUG: CurlEngine curlEnginePool size after release: 3
Due to a termination signal, internal processing stopped abruptly. The application will now exit in a unclean manner.
[1] 25498 segmentation fault (core dumped) ./onedrive --monitor -vvv --debug-https |
Beta Was this translation helpful? Give feedback.
-
OK .. I have tested by excluding 'TestDir' via 'skip_dir' and it certainly gets skipped .... so I do not know why something would have been triggered in that .. as no inotify watch gets created for those directories ..... potentially might need to check your configuration |
Beta Was this translation helpful? Give feedback.
-
This fixed the crashes for me. Thanks a lot! |
Beta Was this translation helpful? Give feedback.
-
This only happens in one of my skip_dir for some reason. I think it's because it was added into skip_dir fairly recently after many files from the directory already synced to the cloud. I'm running a full resync overnight to see if it fixes the issue... |
Beta Was this translation helpful? Give feedback.
-
Thanks for the confirmation. It was an odd regression given I had tested this ... head scratcher. |
Beta Was this translation helpful? Give feedback.
-
No problem - let me know if any further issues. Will merge #2801 into RC3 now. |
Beta Was this translation helpful? Give feedback.
-
Summary of Changes
Important
OneDrive Client for Linux v2.5.0 contains a database schema change to support the additional functionality and bug fixes in the v2.5.x branch. As such, on your first use of this client version, the database schema will be updated and the client will perform an entire re-validation of your data - both locally and online which will take an extended period of time.
Caution
OneDrive Client for Linux v2.5.0 introduces significant changes and is not backwards compatible with v2.4.x. Please ensure that you do not use both v2.5.0 and v2.4.x clients with the same Microsoft OneDrive account simultaneously - whether on the same or different systems. If you upgrade to v2.5.0, all your clients must be updated to this version. However, you can revert to v2.4.x at any time if necessary, but do not run different versions at the same time on any system.
Caution
OneDrive Business Shared Folder Sync has been 100% re-written in v2.5.0. If you are using this feature, please read the new documentation carefully.
Feature Requests
Bug Fixes
Other Changes | Fixes
Documentation
Documentation List
How can you get v2.5.0-rc3 ?
You need to build this client from source. Follow the high level directions here to get the development requirements installed first: https://github.com/abraunegg/onedrive/blob/master/docs/INSTALL.md#building-from-source---high-level-requirements
Next clone and checkout the PR:
To run the PR, you need to run the client from the PR build directory:
When running the PR, your version should be as per below or greater:
The important point is
v2.5.0-rc3-XX-abcdefgas this will change as new commits are put into the Release Candidate PR branch, whilst things are added/fixed/updated.Beta Was this translation helpful? Give feedback.
All reactions