Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtomicPut doesn't compare value #25

Open
mthenw opened this issue Sep 1, 2017 · 2 comments
Open

AtomicPut doesn't compare value #25

mthenw opened this issue Sep 1, 2017 · 2 comments

Comments

@mthenw
Copy link

mthenw commented Sep 1, 2017

Right now AtomicPut doesn't compare value, just ModRevision. Is it intended or not implemented yet? :)

@abronan
Copy link
Owner

abronan commented Sep 1, 2017

You're right, probably just an oversight, vacation didn't help 🏖 😅. I'll look into the remaining issues when I'm back.

@mgood
Copy link

mgood commented Apr 4, 2018

Could you elaborate on what you would want to gain by comparing the value as well?

I'm more familiar with Consul, and there it is intentional to only compare the index. The Consul CAS parameter only takes an index since modifying the value would also modify the index. AFAICT comparing the value would only provide a different result if you passed in an index/value combination that wasn't a valid state that existed in the store. Otherwise it seems like comparing the value would be redundant and slow down operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants