Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): resolve namespace for decorators on primitives #25

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Sep 24, 2024

Changes

  • Fixes the resolveLocalNamesForAll method to also resolve the namespace for decorators on primitive properties of declarations

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Dan Selman <danscode@selman.org>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11019560120

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 95.745%

Totals Coverage Status
Change from base Build 9798635783: 0.6%
Covered Lines: 83
Relevant Lines: 83

💛 - Coveralls

@dselman dselman merged commit 229b6f4 into main Sep 24, 2024
9 checks passed
@dselman dselman deleted the ds-resolve-decorators branch September 24, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants