Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different result on extracting tarball #784

Closed
willysr opened this issue Nov 14, 2024 · 3 comments
Closed

Different result on extracting tarball #784

willysr opened this issue Nov 14, 2024 · 3 comments

Comments

@willysr
Copy link
Collaborator

willysr commented Nov 14, 2024

please take a look on gem submission on ARCHIVE
I ran sbo-bot and it got pushed to SlackBuildsOrg/slackbuilds#8742
it shows that no rc.gem exists, but when i look into the tarball in ARCHIVE, it does exists

willysr@home:~$ tar xvf /data/repo/sbo/ARCHIVE/gem.tar.gz 
gem/
gem/gem.info
gem/gem.8
gem/gem.SlackBuild
gem/doinst.sh
gem/README
gem/slack-desc
gem/rc.gem
@aclemons
Copy link
Owner

The sbo repo has a gitignore on all gem files (rubygems): https://github.com/SlackBuildsOrg/slackbuilds/blob/0068f2d957c654d284d3c95f1df237a72eb8a494/.gitignore#L14

So git add . does not add it:

@aclemons
Copy link
Owner

We could change it to force add everything and ignore the gitignore. Then if there is some rubbish, we'd just need to update the PR while reviewing.

Should we make that change?

@willysr
Copy link
Collaborator Author

willysr commented Nov 14, 2024

ah, didn't think of that
i think i was the one who added that entry in gitignore
since there's only 1 entry who had issue, i think we can change the name of the rc.gem into something else to avoid the .gitignore entry

@willysr willysr closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants