Protocol Review Part 2

[theonlypwner]

Protocol message parsing has already been checked (Google Code Issue 165: #183), but another slow manual check needs to be done.
Malicious values must be handled properly to avoid crashes.

These messages have been checked:

• general
  • before connection is complete
    • SV_SERVINFO
    • SV_WELCOME
  • connection and disconnection
    • SV_INITCLIENT
    • SV_INITAI
    • SV_CDIS
    • SV_DELAI
    • SV_REASSIGNAI
    • SV_RESUME
    • SV_MAPIDENT
  • automatic from client
    • SV_CLIENT
    • SV_POS
    • SV_POSC
    • SV_SOUND
    • SV_PINGPONG
    • SV_CLIENTPING
  • user-initiated
    • SV_TEXT
    • SV_TEXTPRIVATE
    • SV_WHOIS
    • SV_SWITCHNAME
    • SV_SWITCHSKIN
    • SV_THIRDPERSON
    • SV_LEVEL
    • SV_SETTEAM
  • votes
    • SV_CALLVOTE
    • SV_CALLVOTEERR
    • SV_VOTE
    • SV_VOTEREMAIN
    • SV_VOTERESULT
  • demos
    • SV_LISTDEMOS
    • SV_GETDEMO
    • SV_DEMOPLAYBACK
  • auth
    • SV_AUTH_ACR_REQ
    • SV_AUTH_ACR_CHAL
  • privileges
    • SV_CLAIMPRIV
    • SV_SETPRIV
  • map transit
    • SV_SENDMAP
    • SV_RECVMAP
    • SV_REMOVEMAP
• for editmode ONLY
  • SV_EDITMODE
  • SV_EDITH
  • SV_EDITT
  • SV_EDITS
  • SV_EDITD
  • SV_EDITE
  • SV_EDITW
  • SV_EDITENT
  • SV_NEWMAP
• game events
  • client to server
    • SV_SHOOT
    • SV_SHOOTC
    • SV_EXPLODE
    • SV_AKIMBO
    • SV_RELOAD
  • directly handled
    • SV_SUICIDE
    • SV_LOADOUT
    • SV_QUICKSWITCH
    • SV_WEAPCHANGE
    • SV_THROWNADE
    • SV_THROWKNIFE
  • server to client
    • SV_SG
    • SV_RICOCHET
    • SV_HEADSHOT
    • SV_REGEN
    • SV_HEAL
    • SV_BLEED
    • SV_STREAKREADY
    • SV_STREAKUSE
  • knives
    • SV_KNIFEADD
    • SV_KNIFEREMOVE
  • kill confirmed
    • SV_CONFIRMADD
    • SV_CONFIRMREMOVE
• gameplay
  • scoring
    • SV_POINTS
    • SV_SCORE
    • SV_TEAMSCORE
    • SV_DISCSCORES
    • SV_KILL
    • SV_DAMAGE
    • SV_DAMAGEOBJECTIVE
  • spawning
    • SV_TRYSPAWN
    • SV_SPAWNSTATE
    • SV_SPAWN
    • SV_FORCEDEATH
    • SV_FORCEGIB
  • items
    • SV_ITEMSPAWN
    • SV_ITEMACC
  • flags
    • SV_DROPFLAG
    • SV_FLAGINFO
    • SV_FLAGMSG
    • SV_FLAGSECURE
    • SV_FLAGOVERLOAD
  • maps
    • SV_MAPCHANGE
  • round end/remaining
    • SV_ARENAWIN
    • SV_ZOMBIESWIN
    • SV_CONVERTWIN
  • unnamed group 1
    • SV_TIMEUP
• ???
  • unnamed group 2
    • SV_TEAMDENY
    • SV_SERVERMODE
  • unnamed group 3
    • SV_SERVMSG
    • SV_EXTENSION
  • SV_CONNECT = SV_NUM