Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to install without setting override #38

Open
jayvdb opened this issue May 9, 2024 · 2 comments
Open

Ability to install without setting override #38

jayvdb opened this issue May 9, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jayvdb
Copy link

jayvdb commented May 9, 2024

This action has one significant difference to https://github.com/actions-rs/toolchain in that it defaults to overriding the toolchain, whereas the old action only does that if override: true is set.

It would be nice to be able to opt out of that override.

@jonasbb
Copy link
Member

jonasbb commented May 9, 2024

The override is necessary as otherwise it is not possible to use a different toolchain than specified in the rust-toolchain.toml see #26 and #31. Can you please explain what your use case is and why the current way is a problem for you?

The override isn't anything special, so you can get rid of it by executing rustup override unset after this action. I hope that helps.

@jayvdb
Copy link
Author

jayvdb commented May 9, 2024

We install nightly only for its rustfmt , and dont want to build with it.

Yes, I am using rustup override after this github action in order to clear it. I would prefer not having the extra step, by telling this action that I do not want it.

@robjtede robjtede added enhancement New feature or request good first issue Good for newcomers labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

3 participants