Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker :latest should point to master not latest PR build #1371

Open
yarikoptic opened this issue Jun 10, 2024 · 1 comment
Open

docker :latest should point to master not latest PR build #1371

yarikoptic opened this issue Jun 10, 2024 · 1 comment

Comments

@yarikoptic
Copy link
Contributor

yarikoptic commented Jun 10, 2024

ATM

image

so running :latest would result running that PR image.

Ideally, IMHO, :latest should correspond to "latest release" but there seems to be no releases really (and :master to last build on master branch -- all consistent and clear). But it better not to point to some PR (could still be buggy/breaking/etc).

edit 1: it seems to be not quite trivial to filter through all those tags and find commit- tag on docker hub corresponding to master, just need to do it "manually" from looking at commit of current master:

❯ pwd
/home/yoh/proj/misc/qlever
❯ docker pull adfreiburg/qlever:commit-$(git log -1 --format="%h")
commit-e3dcc9c: Pulling from adfreiburg/qlever
7646c8da3324: Pulling fs layer 
...
@joka921
Copy link
Member

joka921 commented Jun 12, 2024

Hi,

  1. All the published docker images correspond to a commit on the Master branch, there is no intermediate work from unfinished PRs on Dockerhub.
  2. The prXXX tag come from our workflow. We consistently squash each PR into a single commit before merging it, thus each commit on the master branch uniquely identifies a PR. This PR is used as one of the tags. In particular that PR number also appears in the commit message of the corresponding commit. Additionally, each image is also tagged with its commit hash. If you compare the git log of the master branch with the names of the provided images, you should be able to observe the correspondence between those two.

Does this answer your questions and address your concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants