Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When using ada as a library and embedding it in our project via FetchContent, we've run into errors like this: ``` [253/1413] Generating ada.cpp, ada.h, ada_c.h, demo.cpp, demo.c, README.md fatal: detected dubious ownership in repository at '/src/redpanda' ``` In our CI environment we've seen flaky HTTP issues as well: ``` CMake Error at build/_deps/ada-src/cmake/CPM.cmake:19 (file): file DOWNLOAD cannot compute hash on failed download status: [22;"HTTP response code said error"] Call Stack (most recent call first): build/_deps/ada-src/CMakeLists.txt:27 (include) CMake Error at build/_deps/ada-src/CMakeLists.txt:32 (CPMAddPackage): Unknown CMake command "CPMAddPackage". ``` Actually building just the library seems very simple and uses vanilla cmake. CPM is only used for testing/benchmarking/etc. We've seen some of the dubious ownership issues just including CPM (hacking around trying to disable GIT failed to fix the issue). To support our usecase, I've added a flag allowing disabling tests, the default value is the value of BUILD_TESTING so hopefully nothing changes for anyone. I tested this via the following commands: ``` cmake -B build && cmake --build build cmake -B build -DADA_BENCHMARKS=ON && cmake --build build cmake -B build -DADA_TESTING=OFF -DADA_TOOLS=OFF -DADA_BENCHMARKS=OFF && cmake --build build ``` Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
- Loading branch information