Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adafruit_CircuitPython_Requests needs update #9036

Closed
bablokb opened this issue Mar 11, 2024 · 1 comment · Fixed by #9046
Closed

Adafruit_CircuitPython_Requests needs update #9036

bablokb opened this issue Mar 11, 2024 · 1 comment · Fixed by #9046
Labels
Milestone

Comments

@bablokb
Copy link

bablokb commented Mar 11, 2024

CircuitPython version

Adafruit CircuitPython 9.0.0-rc.0 on 2024-03-08; Adafruit MagTag with ESP32S2

Code/REPL

n.a.

Behavior

The close() method of Response fails in certain cases. This has already been fixed, see adafruit/Adafruit_CircuitPython_Requests#156 but the submodule here needs an update as well, since it still ships the buggy version (I think circup does this too).

Some boards like the Magtag include Requests as part of the frozen libs, so it is not possible that I ship the fixed version myself.

Description

No response

Additional information

No response

@bablokb bablokb added the bug label Mar 11, 2024
@dhalbert dhalbert added this to the 9.0.0 milestone Mar 11, 2024
@dhalbert
Copy link
Collaborator

I did update the frozen modules for 9.0.0-rc.0, but adafruit_requests needed a new release, which I didn't realize. I've made that release and will update again before final. We should check whether any other libraries need a release as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants