Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up the use of raw_value #27

Open
kodonnell opened this issue Jan 10, 2021 · 0 comments
Open

Tidy up the use of raw_value #27

kodonnell opened this issue Jan 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kodonnell
Copy link
Collaborator

As per #22 there's a bit of potential confusion around the semantics raw_value. That is, it could mean:

That's my bad. Realistically, it's only used for scaling decimal fields, so I think the answer here is to refactor the code so that a 'normal' FieldValue doesn't have all this scaling stuff. Maybe create a ScaledFieldValue? Need to think about that. Then ensure there's only one value thing per (Scaled)FieldValue (not two as we currently have value and raw_value).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant