Skip to content

Latest commit

 

History

History
290 lines (225 loc) · 12.7 KB

CONTRIBUTING.md

File metadata and controls

290 lines (225 loc) · 12.7 KB

Getting started locally

Note: if you're a KA employee and have the webapp repo checked out, you should check perseus out next to webapp, in your /khan folder.

git clone git@github.com:Khan/perseus.git
cd perseus/
git submodule init
git submodule update

After cloning the repo and initializing the submodule, you'll want to open test.html, which is the main page.

You'll need to serve the files from some sort of a server. You can't just open the files directly in a browser.

We recommend installing npm and make, and running 'make server'

cd perseus
make server PORT=9000

Now if you open your browser to http://localhost:9000/test.html (or http://127.0.0.1:9000/test.html) you should see the Perseus question editor.

Fundamental technologies

Here are some technologies that will be important to be familiar with to work with the Perseus source code:

  • We create all Perseus components, including widgets, with React.js.
  • We use underscore for various collection utility functions.
  • We are using several features of ECMAScript 6; most notably arrow functions. (All es6 features are compiled to es5 when building Perseus using make.)
  • We compile our CSS with Less.
  • Some parts of question rendering, answer checking, and hint display are handled by khan-excercises, our legacy exercise framework.
  • For graph or visual widgets, we often make use of:
    • graphie, which exists within khan-exercises, and
    • The React component, a react layer on top of graphie and Interactive2.

And here are some other technologies we use, which are only used by specific parts of the code (and aren't necessary to understand to work with Perseus code):

  • We render math text with KaTeX and MathJax.
  • We use jQuery for low-level dom manipulation for things that are not possible with React.js
  • We use webpack to provide Node.js style require dependencies.
  • Some internal library-ish things:
    • Interactive2, a higher level API on top of several interactive graphie things, and
    • We render Markdown with simple-markdown, a custom extensible markdown parser based on marked.js

Overall architecture

The root React components of perseus are:

  • EditorPage (src/editor-page.jsx): This renders the entire editor, and is what you see on test.html.
  • Editor (src/editor.jsx): This renders the left text editor for the question area, custom-format answer area, or a hint. It manages much of question and widget serialization.
  • ItemRenderer (src/item-renderer.jsx): This is the component that renders the entire item on the site.
  • Renderer: This renders a question area, a custom-format answer area, or a hint. It manages markdown parsing and passing props through to widgets.

Adding widgets

Most of the interactive parts of perseus questions are widgets, such as number-input or transformer. To add more interaction to questions, you probably want to create a new widget or modify an existing widget.

Widgets are all defined in the src/widgets/ directory, and loaded in src/all-widgets.js.

Each widget consists of the following parts:

  • A name which is a unique id slug, such as number-input or example-widget
    • Note: This name must only contain lowercase alphabetic characters and dashes.
  • A displayName which is shown to the user in the "Add widget" menu
  • A widget or "widget renderer", such as NumberInput or ExampleWidget
  • An editor or "widget editor", such as NumberInputEditor or ExampleWidgetEditor
  • An options transform transformation function, which converts the result of widgetEditor.serialize() (generally the editor's props) to the widget renderer's props
  • An options hidden flag, which, if true, will prevent the widget from being available in the widget menu

These are exported in an object at the bottom of every widget file:

Widgets are a combination of two React components: a renderer (i.e. ExampleWidget), and an editor (i.e ExampleWidgetEditor). These are defined in src/widgets/example-widget.jsx, and registered at the bottom of that file.

module.exports = {
    name: "example-widget",
    displayName: "Example Widget",
    hidden: true,   // Hides this widget from the Perseus.Editor widget select
    widget: ExampleWidget,
    editor: ExampleWidgetEditor
};

Then src/all-widgets.js requires this widget to register it:

The relationship between Editors and Widgets

In order to write a functioning widget, it will be important to manage the relationship between the widget's editor, the widget's renderer (aka the widget), and the datastore.

The datastore is the canonical representation of the question. Here's an example of what a simple question looks like:

item = {
    "question": {
        "content": "What is $1 + 1$? [[☃ input-number 1]]",
        "images": {},
        "widgets": {
            "input-number 1": {
                "type": "input-number",
                "graded": true,
                "options": {
                    "value": 2,
                    "simplify": "required",
                    "size": "small",
                    "inexact": false,
                    "maxError": 0.1,
                    "answerType": "number"
                }
            }
        }
    },
    "answerArea": {
        "type": "multiple",
        "options": {
            "content": "Enter the answer in the blank to the left.",
            "images": {},
            "widgets": {}
        },
        "calculator": false
    },
    "hints": []
}

The relevant portion of this for a widget is inside item.question.widgets["input-number 1"], which is the JSON representation of an input-number widget:

"input-number 1": {
    "type": "input-number",
    "graded": true,
    "options": {
        "value": 2,
        "simplify": "required",
        "size": "small",
        "inexact": false,
        "maxError": 0.1,
        "answerType": "number"
    }
}

This is the representation of an input-number that is stored in the datastore. The options field represents the props that are sent to the editor for input-number (InputNumberEditor). The JSON in the datastore is sent as the props to the widget editor.

However, this is not the end of the story of the editor's props. This json version of the props may end up being modified by the editor itself. The most common way this happens is through getDefaultProps(), where a widget editor might expand upon the props sent to it from the datastore with other values that it considers to be missing from these.

As the widget editor is modified (for example, the question writer changes the correct value of the input number to 3), the widget editor will call

this.props.onChange({
    value: 3
});

The props.onChange function is passed into the widget editor by the Perseus Editor component, and allows a widget editor to tell the Editor to send it different props. This pattern is so common that it has been made into a mixin, Changeable, which provides this.change:

var Changeable = require("../mixins/changeable");

var ExampleWidgetEditor = React.createClass({
    // ...
    mixins: [Changeable]

    // ...
    handleAnswerChange(event) {
        this.change({
            correct: event.target.value
        })
    }
    // ...
});

After this change, the following props will be sent down to the ExampleWidgetEditor by the Editor:

"options": {
    "value": 3,
    "simplify": "required",
    "size": "small",
    "inexact": false,
    "maxError": 0.1,
    "answerType": "number"
}

At this point, the question writer probably would like to save the item. When they save the item, the widget editor's serialize() function is called, and the result is set as the options field for that widget and stored in the datastore. The result of serialize() is stored in the datastore. It is important to note that when the question is loaded again, that result of serialize() that has been stored in the datastore will be sent as the props of the widget editor. For that reason, it is important for serialize to return an object compatible with the editor's props.

While it is possible to return things other than the editor's props from serialize(), this is not recommended, and all future widgets should return a strict subset of their editor's props in serialize(). Since this pattern is quite common, we have a mixin to create a correct serialize() function: EditorJsonify. Adding EditorJsonify to the mixins of the widget editor gives the widget editor a serialize() function that returns the widget editor's props minus special props used by React or Perseus.

From here, it is important to understand how these editor props relate to the widget renderer's props. The widget renderer's props are created by calling the transform function exported by the widget on the result of the widget editor's serialize() function (or equivalently on the props from the datastore). If no transform function is registered, the identity function is used in its place. For this reason, many legacy widgets have the same format for their editor props and renderer props, however, this conflation is no longer necessary, and in most cases an explicit transform function can make prop logic clearer.

Between the widgets

In order to get the information from the editor to the renderer, there is big chain of calls of serialize calls with the following hierarchy:

TOP: StatefulEditorPage -> EditorPage -> ItemEditor -> Editor -> WidgetEditor -> (widget’s editor) : BOTTOM

It’s at the EditorPage level that updateRenderer takes EditorPage.serialize and passes it to ItemRenderer, which (on mounting) passes that information to three additional components: Renderer, AnswerAreaRenderer, and HintsRenderer. Each of those in turn identifies the widget type and inserts the information. (In the future, we may streamline this process, delete the serializeQuestion function at the widget’s editor level, and simply extract the props of the widget directly.)

But you might be wondering, "how does it know to update?" That's why we use a heirarchical paradigm of calling

this.props.onChange({updatedParam: newValue}, callbackFunction)

for every update-worthy instance. Similar to serialize, it goes all the way up the hierarchy above and then comes all the way back down, rerendering everything. The results of these renders are then diffed by React, preventing them from causing unnecessary DOM manipulation (and keeping this whole process fast).

Note that there is nothing special about the function onChange--that name is just a convention, and not related to the DOM's onChange event, except in as much as the default React objects use onChange in a way similarly to ours because of the DOM event.

Styles

  • stylesheets/perseus-admin-package has the styles for the Perseus item editor and the rest of the admin pages.
  • stylesheets/exercise-content-package has styles that are shared with exercises.

Starter projects

Perseus is a large and complicated project, and probably not the best first place to start contributing to if you're looking to get involved in Khan Academy open source. We have several more self-contained projects that perseus uses that could definitely use small improvements, such as kmath, KAS, simple-markdown. That said, we're very happy to have quality open source contributions, but have limited time to support this. If you're looking for some projects, I've tried to curate some ideas into the issues list. These should be doable, but are a little more involved than an ideal starter project.

License

MIT License