Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approaching Goti removes already existing opponent goti, even at Safe Spots #37

Open
adi-g15 opened this issue Jan 29, 2021 · 7 comments
Assignees
Labels
beginner bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@adi-g15
Copy link
Owner

adi-g15 commented Jan 29, 2021

In this case, originally there was a blue at the starting point in blue, then the Red goti moved a distance of 4 units, reaching the same spot, and the blue goti went back in locked positions.

Though safe spot logic works for other cases, this is a condition were it is unexpected behaviour, happened twice in the gameplay.

Expected Behaviour:
When the final position has a goti, THEN before attacking & removing, first check if it is one of the safe spots on the board, if it is, then just add this goti to list of gotis on the final box, if not then proceed to attack.

image

@adi-g15 adi-g15 added beginner bug Something isn't working up-for-grabs good first issue Good for newcomers labels Jan 29, 2021
@adi-g15
Copy link
Owner Author

adi-g15 commented Jan 29, 2021

It maybe fixed by us if it remains stale for many days, you can chose to take up the issue if you like 😁

@0shreyajha0
Copy link

i want to work on this. Please assign me and as I am new to this repo please guide me through

@adi-g15
Copy link
Owner Author

adi-g15 commented Jan 16, 2022

Hello @0shreyajha0, you can look at the web/src directory, specially at App.js. (No need to see all code in repo, the website code is inside web/ directory)

First try to replicate this issue (for eg. by setting initial positions of two gotis, then fix dice to return 4(etc) always), eg. Blue Goti is at some stop, and a Red Goti moves to that stop, see what happens.

Then, for eg. if the code removes the Blue goti, then try to look what lines remove a goti, for eg. looking for functions that remove gotis from an array, for eg. splice function etc., but sometimes you may have to look an uncommented code.

And please comment code that you add, so next person that sees understands.

Take as much time as you want, try and experiment in free time : ), the issue is not that important else. (That said, please tell if and when should unassign if so)

@0shreyajha0
Copy link

Thank you for this
I will give my best

@0shreyajha0
Copy link

Sir, the header file game.hpp is not running in vs code can you pls guide

@adi-g15
Copy link
Owner Author

adi-g15 commented Feb 2, 2022

@0shreyajha0 Thanks, you are still trying, the issue itself does not hold much importance elsewise : ).

That file is not needed actually for the issue, and is part of the C++ code.

But, just in case, game.h is a header, that is it is NOT 'run' directly, it is just used (with #include) in some .c or .cpp (etc.) files. So actually, to run the C++ project, just install CMake Extension in vs code, since this project uses CMake so it will be easier to setup in VS Code than setup to compile all files. Then it will ask for 'toolchain', just chose default C++ compiler than you will have buttons to Run or Build in bottom in VSCode/VSCodium, or after building, if you want you can go in build/Debug/ folder, you will find a runnable/executable file, if the project was built (building the project means, just running cmake --build build, which compiles all .cpp files, into an executable),

If it still does not work, let me know, i will create a more detailed documentation for this, so anyone else also can see it 👍

@Athi223
Copy link
Contributor

Athi223 commented Jul 16, 2022

@adi-g15 Hey bro!
Just stumbled across this while I was surfing through my repos.

So do we intend to keep all gotis safe at those places? Or only the ones which belong to their respective starting points?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
None yet
Development

No branches or pull requests

3 participants