-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix relative paths to react (at least in admin) #123
Comments
This is solved for now, but I think there's a more global / dynamic way to solve this issue. For now there might be a way to use a maven profile to kick off a different npm script that would pull react from a different location. I think the root issue was related to some internal react spectrum things trying to run and dying because react was not in apps/admin/app/node_modules. The solution would most likely be:
|
happens again on admin app, hence re-opening, i guess we should go for the long term fix you're proposing @auniverseaway |
out of GH-121, here is instruction to reproduce that issue looks like if you move the build, things don't work anymore (as you could expect with hardcoded relative paths, but it does work for content & structure):
cd apps/admin
mvn clean install && cd target && git clone --depth 1 --branch master git@github.com:adobe/adobe-dx.git checkout && cd checkout
from there if you
cd apps/admin/app
and run the build of the app, you'll have failure, if you do the same for structure or content, it will work. We need to find a way to stop using static hardcoded paths, as we need those both context to work (this checkout context is what is done when doing a release:perform)The text was updated successfully, but these errors were encountered: