Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D implementation ? #36

Open
romainVala opened this issue May 29, 2020 · 4 comments
Open

3D implementation ? #36

romainVala opened this issue May 29, 2020 · 4 comments

Comments

@romainVala
Copy link

Hello

very nice woks !
I do also struggle with spatial shift sensitivity of my 3D CNN and I would like to test your solution.
Is someone aware of a 3D implementation of those filter ? or can you guide us on the implementation ?

Many thanks

@richzhang
Copy link
Contributor

I don't currently have an implementation planned. But yes it should be doable! You can follow my implementation. You'd modify this line to be across 3 dimensions, rather than 2

@romainVala
Copy link
Author

thanks
I can give a try, but the links you post does not work for me ...

@richzhang
Copy link
Contributor

@anirudh-chakravarthy
Copy link

Hi,

Thank you for your work!

I am also trying a 3D implementation. However, ReflectionPad3D is not available in PyTorch, while ReplicationPad3d and ConstantPad3D are. Hence, I was wondering if you evaluated the performance with the equivalent 2D layers in your implementation, and what performance did you observe?

This would give me an idea how important this is, and whether I can use another padding layer interchangeably, or focus on first writing my own 3D reflection padding layer. My guess from your comment in this issue is that it shouldn't matter very much?

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants