Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts do not display closing animation or close button #102

Open
ezpuzz opened this issue Sep 16, 2015 · 1 comment
Open

Alerts do not display closing animation or close button #102

ezpuzz opened this issue Sep 16, 2015 · 1 comment

Comments

@ezpuzz
Copy link

ezpuzz commented Sep 16, 2015

Both Foundation and Bootstrap support closing/dismissing alerts with a close button.

This is more desired behavior than Ember destroying the view itself, although I agree that it needs properly destroyed at some point. Both Foundation and Bootstrap provide events that can be listened to in order to perform this duty, or the alerts could just be destroyed on transition as they do now without much backlash I would think.

Also would allow things like the bootstrap example of buttons embedded within an alert.

@ChrizzDF
Copy link

ChrizzDF commented Jun 9, 2016

Agree. Would be really cool to maybe check if the flash.sticky property is true and then have a closing action on the rendered icon/element. I think that closing/destroying the message by clicking anywhere on it isn't necessary. But I love this addon anyway and looking forward to see future changes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants