-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion Failed with Embroider #690
Comments
I'm also seeing this. In my testing it works fine in Embroider's "Safe" mode which is the mode that offers most backwards compatibility with existing Ember apps. The error seems to occur when Embroider's "Optimized" mode is enabled, i.e. tree-shaking turned on. I have a sample app repo which exhibits the problem. Just load the app and open the homepage, it throws the following error in the console
You can see the validations I added by viewing this commit. They are essentially the ones from the basic ember-cp-validations example in the docs. |
@snewcomer Hello, I saw you fix ember-validators (version 4.0.0). Can you please bump dependency here (ember-cp-validations) to support embroider? |
@offirgolan @snewcomer Can you please update ember-validators dependency for making it embroider treeshaking compatible? |
Environment
Ember: 3.23.1
Ember Data : 3.23.0
Embroider: 0.35.0
Steps to Reproduce
Build app with Embroider and problem here
owner.factoryFor
when validatingUncaught Error: Assertion Failed: Validator not found of type: presence.
The text was updated successfully, but these errors were encountered: