Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After latest upgrade scrollbar is not working in ember-light-table #571

Closed
vishalpareek opened this issue Jul 9, 2018 · 7 comments
Closed

Comments

@vishalpareek
Copy link

I have implemented the ember-light-table in my project, but after the latest upgrade the scrollbar in my table has stopped working. Is there any new configuration introduced in order to get the scrollbar.

@snewcomer
Copy link
Collaborator

@vishalpareek Did 1.13.0 or 1.13.1 break for you?

@vishalpareek
Copy link
Author

I am getting this issue in 1.13.1.

@snewcomer
Copy link
Collaborator

@vishalpareek Any issues with 1.13.0?

@vishalpareek
Copy link
Author

I haven't tried with 1.13.0, i have upgraded it to the latest and now i am facing this issue.

While building my application i am getting below warning,could this be a problem

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least
ember-cli-babel 6.6. Version 5.2.8 located: rdm-new-ui -> ember-light-table ->
ember-scrollable -> ember-component-inbound-actions -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least
ember-cli-babel 6.6. Version 5.2.8 located: rdm-new-ui -> ember-light-table ->
ember-scrollable -> ember-element-resize-detector -> ember-cli-babel

@snewcomer
Copy link
Collaborator

Closer! Would you mind trying out 1.13.0 and let us know if that is broken as well? It will help us hone in on the problem since we don't have an exact reproduction of what you are seeing. 🙇

@tombakerjr
Copy link

I was experiencing this same issue when upgrading from 1.12.2 to 1.13.x (I tried them all). It turns out we use an instance initializer to set all of our tables to have fixed headers by default, so the sharedOptions refactor resulted in our fixedHeader: true on the light-table component being ignored. If I switch to setting fixed: true on the lt-head component, everything works as expected.

@fran-worley
Copy link
Contributor

I believe the confusion here is related to #694

Thanks @tombakerjr for posting a resolution - I'm going to close this as we can track via #694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants