Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ember responsive optional #576

Open
alltouch opened this issue Jul 20, 2018 · 2 comments
Open

Make ember responsive optional #576

alltouch opened this issue Jul 20, 2018 · 2 comments

Comments

@alltouch
Copy link

alltouch commented Jul 20, 2018

We start using ember-light-table in our project and realize that it has ember-responsive dependency. We don't need it and have not been using it.

So i wanted to check is ember-responsive critical dependency for ember-light-table so without it table will not work properly?
Is it any way to remove it from project if table does not need it?

@alexander-alvarez
Copy link
Collaborator

Right now it's only enabled and needed when responsive=true is passed to the light table component, so it should be possible to add a configuration option to exclude it from the dependencies. We'd just have to make sure that any uses of responsive give appropriate erorrs when we've excluded it from the build but one tries to use it https://github.com/offirgolan/ember-light-table/blob/9089723f02ff2c032f18f9d71514b7e0eef51f25/addon/components/light-table.js#L284

Also we'd have to either provide a dummy media service, or configure pieces of code like this:
https://github.com/offirgolan/ember-light-table/blob/9089723f02ff2c032f18f9d71514b7e0eef51f25/addon/components/light-table.js#L43 to not occur unless responsive is used.


As a workaround right now: since ember-responsive gets added to the top level project (ref) you may be able to work around this by removing it as a top level dependency from your app's package.json, and creating a dummy media service in your project ember g service media.

@alltouch
Copy link
Author

@alexander-alvarez Thank you. It works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants