Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be an event when the adapter is "ready"? #152

Open
kellyselden opened this issue Jun 30, 2017 · 0 comments
Open

Should there be an event when the adapter is "ready"? #152

kellyselden opened this issue Jun 30, 2017 · 0 comments

Comments

@kellyselden
Copy link
Collaborator

Stemming from #151 and #86. They are both having issues with race conditions waiting for the upstream script to finish, and what to do with trackEvent calls while it's loading. One option is for the metrics adapter to extend Ember.Evented, and adapters could trigger an event that anyone can listen to. It could be optional, an adapter could choose not to send it.

An adapter could still do its best to queue trackEvent calls while the scripts are loading. The benefit of this change is it would be way easier to test adapters, and a host app may find use out of a hook that fires when the adapter is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant