-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes in 1.4.x #380
Labels
Comments
You're right, my apologies for that. I'll keep this issue open for a few days just in case there are a few other affected consumers. If it's bad enough I'll revert those changes. |
I'm going to revert this, but leave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just a heads-up that moving
utils/object-transform.js
andutils/remove-from-dom.js
into a-private
namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to overridetrackEvent()
in an adapter and useobject-transforms#compact
.Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!
Also, thanks for spending the time keeping this addon maintained and up-to-date!
The text was updated successfully, but these errors were encountered: