Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TKG checks Docker version, but not Podman #503

Closed
LongyuZhang opened this issue Feb 20, 2024 · 4 comments
Closed

TKG checks Docker version, but not Podman #503

LongyuZhang opened this issue Feb 20, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@LongyuZhang
Copy link
Contributor

Currently TKG has the function of checking Docker version, but for machines with Podman, it will show
docker : not on docker
We can add a similar function to check Podman too.

@llxia
Copy link
Contributor

llxia commented May 9, 2024

putInfo(new Info("docker", CHECK_DOCKER_CMD, ce.execute(CHECK_DOCKER_CMD), null));

@llxia
Copy link
Contributor

llxia commented May 9, 2024

We should check both docker --version and podman --version. Please update the current CHECK_DOCKER_CMD and add check for podman.

@llxia llxia added the good first issue Good for newcomers label May 9, 2024
@llxia
Copy link
Contributor

llxia commented Jun 4, 2024

@sophiaxu0424 please take a look at this issue. Thanks

sophiaxu0424 pushed a commit to sophiaxu0424/TKG that referenced this issue Jun 10, 2024
Related to issue: adoptium#503

Signed-off-by: Minghong Xu <Minghong.Xu@ibm.com>
@llxia
Copy link
Contributor

llxia commented Jun 11, 2024

PR #565

@llxia llxia closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants