Mode questions

[knn-k]

I have some questions on ottawa.csv. What are these modes for?

Mode155:
It is enabled only on linux_390-64 and linux_aarch64 configurations.

TKG/resources/modes.xml

Line 1076 in 2326826

<mode number="155">

TKG/resources/ottawa.csv

Line 62 in 2326826

variation:Mode155,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,yes,yes,yes,yes,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,yes,yes,no,no,no,no,no,yes,yes

Mode198 and Mode199:
These modes use the -Xaggressive option, and are enabled only on win_x86-64 and linux_aarch64 configurations.

TKG/resources/modes.xml

Line 1945 in 2326826

<mode number="198">

TKG/resources/modes.xml

Line 1966 in 2326826

<mode number="199">

TKG/resources/ottawa.csv

Lines 91 to 92 in 2326826

	variation:Mode198,no,no,yes,yes,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,yes,yes,no,no,no,no,no,yes,yes
	variation:Mode199,no,no,yes,yes,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,no,yes,yes,no,no,no,no,no,yes,yes

[knn-k]

It seems that I enabled these modes on linux_aarch64_cmprssptrs by mistake when I added the platform by #40.
I opened PR #531 as a fix.

[knn-k]

PR #40 enabled Modes 158 and 159 by mistake.
PR #528 fixes Mode158, and #531 fixes Mode159.

[llxia]

What are these modes for?

The mode is a short name for a list of jvm options. We inherited the old logic from vmfarm.
As you listed above,

• TKG/resources/modes.xml - defines the list of jvm options for each mode
• TKG/resources/ottawa.csv - defines what mode can or cannot run on which platforms. The complexity escalates when it needs to support 64_nocmprssptrs, cmprssptrs, and mixed JVM using one file.

[knn-k]

I think I should have been more clear.
I know what modes.xml and ottawa.csv are used for. I wanted to know the purposes of Modes 155, 198, and 199 specifically.
I am disabling those modes on AArch64 Linux by #531 any way.