Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove view/Dependencies from asmtools URL #546

Open
llxia opened this issue May 7, 2024 · 2 comments
Open

Remove view/Dependencies from asmtools URL #546

llxia opened this issue May 7, 2024 · 2 comments
Assignees
@diyorbekibragimov
Labels
good first issue Good for newcomers

Comments

@llxia
Copy link
Contributor

llxia commented May 7, 2024

We should use a direct 3rd party downloading URL, not a view. If the view changes, the URL will be invalid.

TKG/scripts/getDependencies.pl

Line 128 in e9d595e

url => 'https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/asmtools/asmtools-core-7.0.b10-ea.jar',

Remove view/Dependencies from the URL:

https://ci.adoptium.net/job/dependency_pipeline/lastSuccessfulBuild/artifact/asmtools/asmtools-core-7.0.b10-ea.jar
@llxia llxia added the good first issue Good for newcomers label May 7, 2024
@diyorbekibragimov
Copy link

i'll do it

@llxia
Copy link
Contributor Author

llxia commented Jun 11, 2024

@diyorbekibragimov are you still working on this? If not, that is ok. Just let us know. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diyorbekibragimov diyorbekibragimov

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llxia @diyorbekibragimov