Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homepage CLS problem #555

Closed
tellison opened this issue May 24, 2022 · 5 comments · Fixed by #2069
Closed

Fix homepage CLS problem #555

tellison opened this issue May 24, 2022 · 5 comments · Fixed by #2069
Assignees
Labels
good first issue Good for newcomers

Comments

@tellison
Copy link
Contributor

The adoptium.net homepage shifts the buttons position during load, starting with latest download and release archive,

Screenshot 2022-05-24 at 14 19 30

then inserting other platforms/versions as determined they are available.

Screenshot 2022-05-24 at 14 19 39

This is a usability fail

@gdams gdams added the good first issue Good for newcomers label May 16, 2023
@xavierfacq
Copy link
Member

Hi @tellison

Can you assign me this issue!

@tellison
Copy link
Contributor Author

I see a partial fix (thanks!) on my testing.

The "Other platforms and versions" button is correctly drawn, but the platform name in the subtitle still appears delayed. I see "Download Temurin" change to "Download Temurin for MacOS x64".

Not sure how soon the platform information is available to get the string built early enough.

So I get...
Screenshot 2023-08-17 at 12 10 55

before I get...

Screenshot 2023-08-17 at 12 10 49

@tellison tellison reopened this Aug 17, 2023
@xavierfacq
Copy link
Member

hi @tellison,

Thank you for your feedback 🙏
The platform name in the subtitle appears delayed because it depends of the detected OS in the navigator.

Steps are:

  • print the default button with "Latest LTS Release" with the link to /temurin/releases (good for SEO)
  • detect the OS from the navigator
  • run non-blocking call to retrieve the latest version for the detected OS
  • improve the button to be adapted to the OS

imho it's not a problem, let me know if you want me to investigate more on this point.

@tellison
Copy link
Contributor Author

Thanks for the explanation. It's much better than it was previously, but at least on a slow connection it can still cause the screen to "shift down" as the detected OS is completed and the subtitle is changed. That's not ideal IMHO. No good suggestions about how to resolve it and it is not worth spending much time to fix.

@xavierfacq
Copy link
Member

Even if the issue is closed I can suggest something 😄

What do you think if the button 'Latest LTS releases' is bigger until the async call to finish, in order to have the same height and avoid the screen to "shift down"?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants